Remove --non-interactive flags from build scripts#357
Conversation
--non-interactive is deprecated in newer Expo CLI versions; the recommended replacement is setting CI=1 (or CI=true) in the environment. GitHub Actions already sets CI=true, so expo prebuild just needs the flag removed; the start script explicitly sets CI=1 to be safe. https://claude.ai/code/session_01Kd5nY1iNaeEsUNSF76z1bN
|
commit: |
There was a problem hiding this comment.
Pull request overview
This PR updates CI/build scripts to avoid using Expo CLI’s --non-interactive flag and instead rely on CI-style environment signaling (and default non-interactive behavior in CI environments).
Changes:
- Updated the HealthKit contracts runner to start the Expo/Metro dev server without
--non-interactive, usingCI=1for non-interactive execution. - Updated the GitHub Actions iOS prebuild step to run
expo prebuildwithout--non-interactive.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/example/scripts/run-healthkit-contracts.sh | Starts the dev server without --non-interactive, using CI=1 for non-interactive behavior during contract runs. |
| .github/workflows/test.yml | Removes --non-interactive from the iOS expo prebuild step in CI. |
Summary
Removes the
--non-interactiveflag from Expo prebuild and Metro bundler commands, replacing it with theCI=1environment variable for the Metro bundler to better align with standard CI/CD practices.Changes
--non-interactiveflag from the iOS prebuild command in the GitHub Actions workflow--non-interactiveflag withCI=1environment variable in the HealthKit contracts test scriptDetails
These changes modernize the build configuration by:
CI=1) instead of command-line flags for CI detection in MetroCIenvironment variable is the canonical way to indicate a continuous integration contexthttps://claude.ai/code/session_01Kd5nY1iNaeEsUNSF76z1bN