refactor: replace with-patch context managers with @patch decorators in tests

Author: stephen-kintsugi

tests/test_generate_sql.py

@@ -16,7 +16,8 @@ def write_file(tmp_path, source):
     return str(path)
 
 
-def test_returns_sql_for_valid_migration(tmp_path):
+@patch("subprocess.run")
+def test_returns_sql_for_valid_migration(mock_run, tmp_path):
     path = write_file(
         tmp_path,
         """
@@ -28,11 +29,8 @@ def upgrade():
         """,
     )
     expected_sql = "CREATE TABLE foo (id int);\n"
-    with patch(
-        "subprocess.run",
-        return_value=make_result(stdout=expected_sql),
-    ):
-        assert generate_sql(path) == expected_sql
+    mock_run.return_value = make_result(stdout=expected_sql)
+    assert generate_sql(path) == expected_sql
 
 
 def test_returns_none_for_unparseable_file(tmp_path):
@@ -67,7 +65,8 @@ def upgrade():
     assert generate_sql(path) is None
 
 
-def test_uses_base_when_down_revision_is_none(tmp_path):
+@patch("subprocess.run")
+def test_uses_base_when_down_revision_is_none(mock_run, tmp_path):
     path = write_file(
         tmp_path,
         """
@@ -78,16 +77,14 @@ def upgrade():
             pass
         """,
     )
-    with patch(
-        "subprocess.run",
-        return_value=make_result(stdout="CREATE TABLE foo (id int);\n"),
-    ) as mock_run:
-        generate_sql(path)
-        cmd = mock_run.call_args[0][0]
-        assert "base:first001" in cmd
+    mock_run.return_value = make_result(stdout="CREATE TABLE foo (id int);\n")
+    generate_sql(path)
+    cmd = mock_run.call_args[0][0]
+    assert "base:first001" in cmd
 
 
-def test_raises_on_alembic_failure(tmp_path):
+@patch("subprocess.run")
+def test_raises_on_alembic_failure(mock_run, tmp_path):
     path = write_file(
         tmp_path,
         """
@@ -98,15 +95,13 @@ def upgrade():
             pass
         """,
     )
-    with patch(
-        "subprocess.run",
-        return_value=make_result(returncode=1, stderr="some error"),
-    ):
-        with pytest.raises(GenerateSqlError, match="alembic upgrade --sql failed"):
-            generate_sql(path)
+    mock_run.return_value = make_result(returncode=1, stderr="some error")
+    with pytest.raises(GenerateSqlError, match="alembic upgrade --sql failed"):
+        generate_sql(path)
 
 
-def test_raises_when_alembic_not_found(tmp_path):
+@patch("subprocess.run")
+def test_raises_when_alembic_not_found(mock_run, tmp_path):
     path = write_file(
         tmp_path,
         """
@@ -117,12 +112,13 @@ def upgrade():
             pass
         """,
     )
-    with patch("subprocess.run", side_effect=FileNotFoundError):
-        with pytest.raises(GenerateSqlError, match="alembic not found"):
-            generate_sql(path)
+    mock_run.side_effect = FileNotFoundError
+    with pytest.raises(GenerateSqlError, match="alembic not found"):
+        generate_sql(path)
 
 
-def test_provides_dummy_database_url_when_unset(tmp_path, monkeypatch):
+@patch("subprocess.run")
+def test_provides_dummy_database_url_when_unset(mock_run, tmp_path, monkeypatch):
     monkeypatch.delenv("DATABASE_URL", raising=False)
     path = write_file(
         tmp_path,
@@ -134,16 +130,14 @@ def upgrade():
             pass
         """,
     )
-    with patch(
-        "subprocess.run",
-        return_value=make_result(stdout="SQL;\n"),
-    ) as mock_run:
-        generate_sql(path)
-        env = mock_run.call_args[1]["env"]
-        assert env["DATABASE_URL"] == "postgresql://localhost/lint"
+    mock_run.return_value = make_result(stdout="SQL;\n")
+    generate_sql(path)
+    env = mock_run.call_args[1]["env"]
+    assert env["DATABASE_URL"] == "postgresql://localhost/lint"
 
 
-def test_preserves_existing_database_url(tmp_path, monkeypatch):
+@patch("subprocess.run")
+def test_preserves_existing_database_url(mock_run, tmp_path, monkeypatch):
     monkeypatch.setenv("DATABASE_URL", "postgresql://real-host/real-db")
     path = write_file(
         tmp_path,
@@ -155,10 +149,7 @@ def upgrade():
             pass
         """,
     )
-    with patch(
-        "subprocess.run",
-        return_value=make_result(stdout="SQL;\n"),
-    ) as mock_run:
-        generate_sql(path)
-        env = mock_run.call_args[1]["env"]
-        assert env["DATABASE_URL"] == "postgresql://real-host/real-db"
+    mock_run.return_value = make_result(stdout="SQL;\n")
+    generate_sql(path)
+    env = mock_run.call_args[1]["env"]
+    assert env["DATABASE_URL"] == "postgresql://real-host/real-db"