Don't assume in transaction

[mventnor-kintsugi]

Alembic does wrap in BEGIN/COMMIT when exporting

Summary by CodeRabbit

• Bug Fixes

  • Removed an unnecessary transactional assumption when validating generated SQL, improving validation behavior.

• Tests

  • Adjusted tests to no longer require the previous transactional-assumption behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between dc9910f and 5174b97.

📒 Files selected for processing (1)

• tests/test_main.py

💤 Files with no reviewable changes (1)

• tests/test_main.py

---

Walkthrough

The Alembic hook's squawk subprocess invocation was changed to omit the --assume-in-transaction flag when running against the temporary SQL file. The corresponding test was relaxed to no longer assert that the flag is present. No other logic or public signatures were modified.

Changes

Cohort / File(s)	Summary
Subprocess flag removal squawk_alembic/hook.py	Removed --assume-in-transaction from the squawk subprocess command line; command invocation, error handling, and cleanup logic otherwise unchanged.
Test update tests/test_main.py	Removed assertion that --assume-in-transaction appears in the squawk invocation, allowing the command to be executed without that flag in tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Don't assume in transaction' directly reflects the main change: removing the --assume-in-transaction flag from the squawk subprocess invocation.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bug/no-assume-transaction

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}