fix(storage): extract with dir= must not mutate dir (download, logs)

Author: gadicc

api/download.py

@@ -76,6 +76,7 @@ async def download_model(
         exists = storage.file_exists()
         if exists:
             model_dir = os.path.join(MODELS_DIR, normalized_model_id)
+            print("model_dir", model_dir)
             await asyncio.to_thread(storage.download_and_extract, model_file, model_dir)
         else:
             if checkpoint_url:

api/utils/storage/BaseStorage.py

@@ -31,9 +31,9 @@ def test(path):
     def extract(self, dir, dry_run=False):
         self.updateStatus("extract", 0)
         if not dir:
-            dir = os.path.dirname(self.path)
-        base, ext, subext = self.splitext()
-        dir = os.path.join(dir, base)
+            base, ext, subext = self.splitext()
+            parent_dir = os.path.dirname(self.path)
+            dir = os.path.join(parent_dir, base)
 
         if not dry_run:
             os.mkdir(dir)
@@ -46,10 +46,11 @@ def track_progress(tar):
                     self.updateStatus("extract", i / len(members))
                     yield member
 
+            print("Extracting to " + dir)
             with tarfile.open(self.path, "r") as tar:
                 tar.extractall(path=dir, members=track_progress(tar))
                 tar.close()
-            subprocess.run(["ls", "-l"])
+            subprocess.run(["ls", "-l", dir])
             os.remove(self.path)
 
         self.updateStatus("extract", 1)