Commit 427374f
authored
fix: wrong
## 📜 Description
Add support for `windowDidResize` event on iOS.
## 💡 Motivation and Context
In
#948
I changed implementation and added subscription to `screen` values
instead of `window`.
While it fixes some issues it doesn't work on iPad 🤯 This is very sad
that such basic functionality can not be handled by RN out-of-the-box.
However we already use own `useWindowDimensions` hook on Android. So in
this PR I decided to replicate that behavior on iOS.
`react-native-safe-area-context` doesn't have that problem, but
`react-native-safe-area-context` handles that event in `layoutSubviews`.
After thinking a while I decided to use the same approach and emit event
`windowDidResize`. And this approach actually works 🙂 I also added a
check to not emit events too frequently if dimensions weren't changed.
The PR
#956
also aims to solve that problem, but `useWindowDimensions` is used by
other components, such as
`KeyboardAvoidingView`/`KeyboardAwareScrollView`, so the problem should
be fixed in hook itself.
Closes
#955
## 📢 Changelog
<!-- High level overview of important changes -->
<!-- For example: fixed status bar manipulation; added new types
declarations; -->
<!-- If your changes don't affect one of platform/language below - then
remove this platform/language -->
### iOS
- emit `windowDidResize` event with device screen dimensions;
## 🤔 How Has This Been Tested?
Tested manually in reproduction example + by e2e tests.
## 📸 Screenshots (if appropriate):

## 📝 Checklist
- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changeduseWindowDimensions on iPad (#957)1 parent c5c0077 commit 427374f
5 files changed
Lines changed: 49 additions & 60 deletions
File tree
- ios
- views
- src/hooks/useWindowDimensions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| 122 | + | |
| 123 | + | |
122 | 124 | | |
123 | 125 | | |
124 | 126 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
| 41 | + | |
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
| |||
211 | 213 | | |
212 | 214 | | |
213 | 215 | | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
214 | 232 | | |
215 | 233 | | |
216 | 234 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
| |||
83 | 85 | | |
84 | 86 | | |
85 | 87 | | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
86 | 105 | | |
87 | 106 | | |
88 | 107 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
4 | 6 | | |
5 | 7 | | |
6 | 8 | | |
| |||
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
| 15 | + | |
| 16 | + | |
18 | 17 | | |
19 | 18 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | 19 | | |
32 | 20 | | |
33 | 21 | | |
34 | 22 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
41 | 29 | | |
42 | 30 | | |
43 | 31 | | |
| |||
0 commit comments