Commit 4bdf4e5
authored
fix: types mismatch for
## 📜 Description
Updated jsdoc and type declaration for `dismiss` method.
## 💡 Motivation and Context
The `options` object serves asa configuration object. We may skip some
properties and it should use default options then. In fact our
implementation already has correct options:
```tsx
const dismiss = async (options?: Partial<DismissOptions>): Promise<void> => {
```
So in this PR I just reflected it in types 🙃
## 📢 Changelog
<!-- High level overview of important changes -->
<!-- For example: fixed status bar manipulation; added new types
declarations; -->
<!-- If your changes don't affect one of platform/language below - then
remove this platform/language -->
### JS
- changed JSDoc of `dismiss` method;
- marked options as `Partial` in `types` declaration file.
## 🤔 How Has This Been Tested?
Tested in example project.
## 📸 Screenshots (if appropriate):
|Before|After|
|------|------|
|<img width="915" height="174" alt="Screenshot 2025-12-01 at 10 13 27"
src="https://github.com/user-attachments/assets/ad515fc9-c79f-4b65-afc6-6bb1608429ad"
/>|<img width="614" height="102" alt="image"
src="https://github.com/user-attachments/assets/05e51607-acb8-443c-bac5-a7d39b6a8537"
/>|
## 📝 Checklist
- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changeddismiss method (#1225)1 parent 14ededa commit 4bdf4e5
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| 88 | + | |
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
91 | | - | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
| |||
0 commit comments