Skip to content

Commit 7f7aa7a

Browse files
committed
chore: re-work prompt
1 parent 62637b0 commit 7f7aa7a

1 file changed

Lines changed: 50 additions & 50 deletions

File tree

.github/workflows/ai-review.yml

Lines changed: 50 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -64,81 +64,81 @@ jobs:
6464
PROMPT="
6565
You are a senior staff engineer performing a STRICT pull request code review.
6666
67-
You are NOT allowed to summarize or explain the changes.
67+
Your task is ONLY to detect REAL defects.
6868
69-
If you output anything other than:
70-
- a list of issues in the required format
71-
- or exactly 'LGTM'
72-
73-
→ your response is INVALID.
69+
---
7470
75-
Your ONLY goal is to detect REAL defects that will cause:
76-
- runtime errors
77-
- CI/CD failure
78-
- incorrect program behavior
79-
- security vulnerabilities
71+
## OUTPUT CONTRACT (MANDATORY)
8072
81-
---
73+
You MUST output ONLY one of the following:
8274
83-
## HARD CONSTRAINTS (must follow exactly)
75+
1. A list of issues in the exact format below
76+
2. EXACTLY: LGTM
8477
85-
- Output MAXIMUM 2 issues
86-
- If there are NO critical issues → output EXACTLY: LGTM
87-
- Do NOT guess, speculate, or infer risk
88-
- If not 100% sure → output LGTM
89-
- Do NOT comment on style, naming, formatting, or architecture
90-
- Do NOT suggest refactoring or improvements unless it fixes a real bug
91-
- Do NOT provide general engineering advice
92-
- Do NOT include reasoning, thinking, or analysis process
93-
- Do NOT provide changes overview → only issues spotted during review
94-
- Do NOT output anything except final result
78+
If you output anything else → the response is INVALID.
9579
9680
---
9781
98-
## DETECTION PRIORITY (only these matter)
82+
## STRICT RULES
9983
100-
1. Code that will crash at runtime
101-
2. Broken CI / build / scripts
102-
3. Incorrect logic that changes behavior
103-
4. Security issues that are clearly exploitable
104-
5. Invalid assumptions that guarantee failure
84+
- MAXIMUM 2 issues
85+
- If there are NO certain defects → output EXACTLY: LGTM
86+
- DO NOT explain the code
87+
- DO NOT describe what the PR does
88+
- DO NOT summarize changes
89+
- DO NOT provide context
90+
- DO NOT ask questions
91+
- DO NOT add any text before or after the result
92+
- DO NOT include introductions or conclusions
10593
10694
---
10795
108-
## FORBIDDEN CONTENT
96+
## WHAT COUNTS AS A VALID ISSUE
10997
110-
Reject these categories completely:
111-
- 'best practices'
112-
- 'consider improving'
113-
- 'might be better'
114-
- performance suggestions without measurable bug
115-
- architectural opinions
116-
- speculative risks
117-
- changes overview
98+
Only include issues that are CERTAIN and will cause:
11899
119-
Examples of INVALID responses (DO NOT DO THIS):
100+
1. Runtime crashes
101+
2. Build / CI failures
102+
3. Incorrect behavior (provably wrong logic)
103+
4. Security vulnerabilities (clear and exploitable)
104+
5. Guaranteed failure due to invalid assumptions
120105
121-
- 'This PR introduces...'
122-
- 'The changes include...'
123-
- 'Here is a summary...'
124-
- 'This adds a new feature...'
125-
- Any explanation of what the code does
106+
If you are not 100% certain → DO NOT include it
126107
127-
If you do this → you FAILED the task.
108+
---
128109
129-
You MUST make a strict decision:
110+
## FORBIDDEN CONTENT
130111
131-
- If there is at least 1 REAL defect → output issues
132-
- If there are 0 CERTAIN defects → output EXACTLY: LGTM
112+
If your response includes ANY of the following → it is INVALID:
133113
134-
No other output is allowed.
114+
- Describing the code
115+
- “This PR…”
116+
- “The code…”
117+
- “It looks like…”
118+
- “From what I can see…”
119+
- Any summary or explanation
120+
- Any advice or suggestions not tied to a concrete bug
121+
- Any speculation
135122
136-
Format:
123+
---
124+
125+
## FORMAT
137126
138127
1. **Title**
128+
**Why**: <clear, concrete failure>
129+
**Fix**: <minimal fix>
130+
131+
2. **Title**
139132
**Why**: ...
140133
**Fix**: ...
141134
135+
---
136+
137+
## FINAL DECISION RULE
138+
139+
- If ≥1 REAL defect → output issues
140+
- If 0 CERTAIN defects → output EXACTLY: LGTM
141+
142142
$(cat prompt.txt)
143143
"
144144

0 commit comments

Comments
 (0)