Commit 838f546
authored
Call correct onInterceptHoverEvent super in onInterceptHoverEvent() (#1260)
## 📜 Description
Fix a copy/paste mistake in
`OverKeyboardRootViewGroup.onInterceptHoverEvent`. The method
incorrectly delegates to `super.onHoverEvent(event)` instead of
`super.onInterceptHoverEvent(event)`, which bypasses the proper
intercept path for hover events.
This change updates the return statement to call the correct superclass
method.
## 💡 Motivation and Context
`onInterceptHoverEvent` is specifically intended to decide whether hover
events should be intercepted before reaching child views. Calling
`super.onHoverEvent` from the intercept override is incorrect and can
lead to inconsistent hover/pointer behavior (including
accessibility/hover dispatch) compared to the expected ViewGroup event
flow.
This appears to be a straightforward copy/paste error given that
`onHoverEvent` already calls `super.onHoverEvent(event)`.
`react-native` PR for reference:
react/react-native#54991
## 📢 Changelog
### Android
* Fixed `onInterceptHoverEvent` to call
`super.onInterceptHoverEvent(event)` instead of
`super.onHoverEvent(event)`.1 parent b5fb835 commit 838f546
1 file changed
Lines changed: 1 addition & 1 deletion
File tree
- android/src/main/java/com/reactnativekeyboardcontroller/views/overlay
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
200 | | - | |
| 200 | + | |
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
| |||
0 commit comments