Commit 9080f31
authored
fix: allow keyboard toolbar take all available space (#865)
## 📜 Description
Apply arrow/done paddings on elements level, not entire container, so
that conditional rendering will exclude potentially undesired paddings.
## 💡 Motivation and Context
Potentially "padding by default" approach may be not desired when you
want your custom element (content) to place that space.
So in this PR I re-worked an approach, and if done/arrows are hidden,
then `content` will fill entire container.
Closes
#848
Successor of
#851
## 📢 Changelog
<!-- High level overview of important changes -->
<!-- For example: fixed status bar manipulation; added new types
declarations; -->
<!-- If your changes don't affect one of platform/language below - then
remove this platform/language -->
### JS
- removed `paddingHorizontal` from main container;
- added container for arrows and apply padding there;
- apply padding (+8px) to Done button (to compensate removed padding
from main container);
## 🤔 How Has This Been Tested?
Tested manually on iPhone 15 Pro (iOS 17.5 Fabric).
## 📸 Screenshots (if appropriate):
|No arrows|No done button|No toolbar elements|All elements|
|----------|----------------|--------------------|------------|
|||||
## 📝 Checklist
- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changed1 parent 5b65344 commit 9080f31
1 file changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
| 159 | + | |
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
188 | | - | |
| 188 | + | |
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
225 | | - | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
226 | 229 | | |
227 | 230 | | |
228 | 231 | | |
229 | 232 | | |
230 | 233 | | |
231 | 234 | | |
232 | | - | |
| 235 | + | |
| 236 | + | |
233 | 237 | | |
234 | 238 | | |
235 | 239 | | |
| |||
0 commit comments