chore: changes after self review

Author: kirillzyusko

android/src/main/java/com/reactnativekeyboardcontroller/listeners/KeyboardAnimationCallback.kt

@@ -51,7 +51,6 @@ class KeyboardAnimationCallback(
   val view: View,
   val context: ThemedReactContext?,
   private val config: KeyboardAnimationCallbackConfig,
-  private val source: KeyboardAnimationCallback? = null,
 ) : WindowInsetsAnimationCompat.Callback(config.dispatchMode),
   OnApplyWindowInsetsListener,
   Suspendable {
@@ -173,7 +172,7 @@ class KeyboardAnimationCallback(
     if (prevKeyboardHeight != newHeight && !isMoving && !isSuspended) {
       Logger.w(
         TAG,
-        "detected desynchronized state - force updating it. $prevKeyboardHeight -> $newHeight. Attached: ${view.isAttachedToWindow} EVA: ${this.eventPropagationView.isAttachedToWindow} Modal ${this.source}",
+        "detected desynchronized state - force updating it.",
       )
       this.syncKeyboardPosition(newHeight, newHeight > 0)
     }
@@ -184,8 +183,6 @@ class KeyboardAnimationCallback(
   override fun onPrepare(animation: WindowInsetsAnimationCompat) {
     super.onPrepare(animation)
 
-    println("desynchronized - onPrepare")
-
     if (!animation.isKeyboardAnimation || isSuspended) {
       return
     }

android/src/main/java/com/reactnativekeyboardcontroller/modal/ModalAttachedWatcher.kt

@@ -33,7 +33,6 @@ class ModalAttachedWatcher(
       return
     }
 
-    val cb = this.callback()
     val modal =
       try {
         uiManager?.resolveView(event.viewTag) as? ReactModalHostView
@@ -45,9 +44,6 @@ class ModalAttachedWatcher(
     if (modal == null) {
       return
     }
-    if (cb == null) {
-      return
-    }
 
     val dialog = modal.dialog
     val window = dialog?.window
@@ -64,7 +60,6 @@ class ModalAttachedWatcher(
           eventPropagationView = view,
           context = reactContext,
           config = config,
-          source = cb,
         )
 
       rootView.addView(eventView)
@@ -73,10 +68,9 @@ class ModalAttachedWatcher(
         // on Android < 12 all events for `WindowInsetsAnimationCallback`
         // go through main `rootView`, so we don't need to stop main
         // callback - otherwise keyboard transitions will not be animated
-        cb.suspend(true)
+        this.callback()?.suspend(true)
         // attaching callback to Modal on Android < 12 can cause ghost animations, see: https://github.com/kirillzyusko/react-native-keyboard-controller/pull/718
-        // and overall attaching additional callbacks (if animation events go through the main window)
-        // is not necessary
+        // and overall attaching additional callbacks (if animation events go through the main window) is not necessary
         ViewCompat.setWindowInsetsAnimationCallback(rootView, callback)
         ViewCompat.setOnApplyWindowInsetsListener(eventView, callback)
       }