Skip to content

Commit a425e7c

Browse files
Mhp23kirillzyusko
andauthored
fix: react native 0.73.x build failing when new arch is enabled on iOS (#304)
## 📜 Description Updating Pod to add Yoga style to HEADER_SEARCH_PATHS for new architecture ## 💡 Motivation and Context For react native (0.73.X) build failing when new architecture is enabled on iOS. ## 📢 Changelog Fix: `yoga/style/Style.h` not found when new arch is enabled on iOS ### iOS - `yoga/style/Style.h` header has added to `HEADER_SEARCH_PATHS` on iOS Pods. ## 🤔 How Has This Been Tested? ## 📸 Screenshots (if appropriate): <img width="1352" alt="keyboard-controller" src="https://github.com/kirillzyusko/react-native-keyboard-controller/assets/52624436/5504a6e4-5627-41ad-ac46-df8a3d3bd762"> ## 📝 Checklist - [X] CI successfully passed --------- Co-authored-by: kirillzyusko <zyusko.kirik@gmail.com>
1 parent 1651da4 commit a425e7c

5 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/build-ios-fabric.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ on:
1717
- main
1818
paths:
1919
- '.github/workflows/build-ios-fabric.yml'
20+
- 'react-native-keyboard-controller.podspec'
2021
- 'ios/**'
2122
- 'FabricExample/ios/**'
2223
- 'yarn.lock'

.github/workflows/build-ios.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ on:
1616
- main
1717
paths:
1818
- '.github/workflows/build-ios.yml'
19+
- 'react-native-keyboard-controller.podspec'
1920
- 'ios/**'
2021
- 'example/ios/**'
2122
- 'yarn.lock'

FabricExample/ios/Podfile.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1407,7 +1407,7 @@ SPEC CHECKSUMS:
14071407
React-jsiexecutor: c7f826e40fa9cab5d37cab6130b1af237332b594
14081408
React-jsinspector: aaed4cf551c4a1c98092436518c2d267b13a673f
14091409
React-logger: da1ebe05ae06eb6db4b162202faeafac4b435e77
1410-
react-native-keyboard-controller: e5f3a9a87ed7594ee6b400accc74d012f44b969e
1410+
react-native-keyboard-controller: 567097b4c14e2632a3fd6cce7a583cff8e5734e2
14111411
react-native-safe-area-context: a283130af276caa22ecfed30c3d1eb450bc83439
14121412
React-NativeModulesApple: edb5ace14f73f4969df6e7b1f3e41bef0012740f
14131413
React-perflogger: 496a1a3dc6737f964107cb3ddae7f9e265ddda58

example/ios/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ EXTERNAL SOURCES:
697697
SPEC CHECKSUMS:
698698
boost: 57d2868c099736d80fcd648bf211b4431e51a558
699699
CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
700-
DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
700+
DoubleConversion: fea03f2699887d960129cc54bba7e52542b6f953
701701
FBLazyVector: 5d4a3b7f411219a45a6d952f77d2c0a6c9989da5
702702
FBReactNativeSpec: 3fc2d478e1c4b08276f9dd9128f80ec6d5d85c1f
703703
Flipper: 6edb735e6c3e332975d1b17956bcc584eccf5818
@@ -709,7 +709,7 @@ SPEC CHECKSUMS:
709709
Flipper-PeerTalk: 116d8f857dc6ef55c7a5a75ea3ceaafe878aadc9
710710
FlipperKit: 2efad7007d6745a3f95e4034d547be637f89d3f6
711711
fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
712-
glog: 04b94705f318337d7ead9e6d17c019bd9b1f6b1b
712+
glog: c5d68082e772fa1c511173d6b30a9de2c05a69a2
713713
hermes-engine: 81191603c4eaa01f5e4ae5737a9efcf64756c7b2
714714
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
715715
lottie-ios: 809ecf2d460ed650a6aed7aa88b2ec45fab4779c

react-native-keyboard-controller.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Pod::Spec.new do |s|
2424
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
2525
s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
2626
s.pod_target_xcconfig = {
27-
"HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
27+
"HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\" \"${PODS_ROOT}/Headers/Private/Yoga\"",
2828
"OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
2929
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
3030
# This is handy when we want to detect if new arch is enabled in Swift code

0 commit comments

Comments
 (0)