Commit afeccd1
authored
fix: shorter codegen name (#1251)
## 📜 Description
Use `keyboardcontroller` instead of `reactnativekeyboardcontroller` as
c++ library name.
## 💡 Motivation and Context
Using `reactnativekeyboardcontroller` produces very long pathnames, for
example:
`reactnativekeyboardcontroller_autolinked_build/CMakeFiles/react_codegen_reactnativekeyboardcontroller.dir/C_/Users/irust/connect/node_modules/react-native-keyboard-controller/common/cpp/react/renderer/components/reactnativekeyboardcontroller/RNKCKeyboardBackgroundViewShadowNode.cpp.o`
-> 282 symbols (which exceeds the limit of 260 characters on Windows).
With `keyboardcontroller` it will be
`keyboardcontroller_autolinked_build/CMakeFiles/react_codegen_keyboardcontroller.dir/C_/Users/irust/connect/node_modules/react-native-keyboard-controller/common/cpp/react/renderer/components/keyboardcontroller/RNKCKeyboardBackgroundViewShadowNode.cpp.o`
(which is only 251 symbol).
This PR will not fix all problems with linking on windows, but at least
if project is close to the beginning of the root of the disk (i. e.
`C_/Users/irust/connect`) the project will be assembled without errors
🤷♂️
> [!IMPORTANT]
> I had to remove
`FabricExample/android/build/generated/autolinking/autolinking.json` so
that the file can be re-assembled again to avoid compilation errors.
Closes
#1147
#1247
## 📢 Changelog
<!-- High level overview of important changes -->
<!-- For example: fixed status bar manipulation; added new types
declarations; -->
<!-- If your changes don't affect one of platform/language below - then
remove this platform/language -->
### JS
- change `reactnativekeyboardcontroller` -> `keyboardcontroller`
### iOS
- change `reactnativekeyboardcontroller` -> `keyboardcontroller`
### Android
- change `reactnativekeyboardcontroller` -> `keyboardcontroller`
### C++
- change `reactnativekeyboardcontroller` -> `keyboardcontroller`
## 🤔 How Has This Been Tested?
Tested manually via this PR + locally run fabric build on iOS/Android.
## 📸 Screenshots (if appropriate):
<img width="250" height="516" alt="image"
src="https://github.com/user-attachments/assets/7bd374cb-2b39-4474-808c-654d918698dd"
/>
## 📝 Checklist
- [x] CI successfully passed
- [x] I added new mocks and corresponding unit-tests if library API was
changed1 parent cca8cc2 commit afeccd1
33 files changed
Lines changed: 64 additions & 64 deletions
File tree
- FabricExample/ios
- android/src/main/jni
- common/cpp/react/renderer/components/keyboardcontroller
- ios
- views
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3117 | 3117 | | |
3118 | 3118 | | |
3119 | 3119 | | |
3120 | | - | |
| 3120 | + | |
3121 | 3121 | | |
3122 | 3122 | | |
3123 | 3123 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
0 commit comments