fix: changes after self review (actually working code)

Author: kirillzyusko

android/src/fabric/java/com/reactnativekeyboardcontroller/KeyboardControllerModule.kt

@@ -11,7 +11,9 @@ class KeyboardControllerModule(
 
   override fun getName(): String = KeyboardControllerModuleImpl.NAME
 
-  override fun getConstants(): MutableMap<String, Any> = mutableMapOf("keyboardBorderRadius" to 0)
+  override fun getTypedExportedConstants(): Map<String, Any> {
+    return module.getConstants()
+  }
 
   override fun setInputMode(mode: Double) {
     module.setInputMode(mode.toInt())

android/src/main/java/com/reactnativekeyboardcontroller/modules/KeyboardControllerModuleImpl.kt

@@ -23,6 +23,7 @@ class KeyboardControllerModuleImpl(
   private val controller = KeyboardAnimationController()
   private val mDefaultMode: Int = getCurrentMode()
 
+  // region Module methods
   fun setInputMode(mode: Int) {
     setSoftInputMode(mode)
   }
@@ -102,7 +103,9 @@ class KeyboardControllerModuleImpl(
       promise.resolve(map)
     }
   }
+  // endregion
 
+  // region Helpers
   private fun setSoftInputMode(mode: Int) {
     UiThreadUtil.runOnUiThread {
       if (getCurrentMode() != mode) {
@@ -118,8 +121,13 @@ class KeyboardControllerModuleImpl(
       ?.attributes
       ?.softInputMode
       ?: WindowManager.LayoutParams.SOFT_INPUT_STATE_UNSPECIFIED
+  // endregion
+
+  // region Module constants
+  fun getConstants(): MutableMap<String, Any> = mutableMapOf("keyboardBorderRadius" to 0)
 
   companion object {
     const val NAME = "KeyboardController"
   }
+  // endregion
 }

android/src/paper/java/com/reactnativekeyboardcontroller/KeyboardControllerModule.kt

@@ -13,7 +13,7 @@ class KeyboardControllerModule(
 
   override fun getName(): String = KeyboardControllerModuleImpl.NAME
 
-  override fun getConstants(): MutableMap<String, Any> = mutableMapOf("keyboardBorderRadius" to 0)
+  override fun getConstants(): MutableMap<String, Any> = module.getConstants()
 
   @ReactMethod
   fun setInputMode(mode: Int) {

e2e/kit/assets/ios/iPhone 17 Pro/ToolbarAllButtonsEnabled.png

@@ -60,6 +60,11 @@ - (NSDictionary *)constantsToExport
   };
 }
 
+- (NSDictionary *)getConstants
+{
+  return [self constantsToExport];
+}
+
 #ifdef RCT_NEW_ARCH_ENABLED
 - (void)setDefaultMode
 #else

e2e/kit/assets/ios/iPhone 17 Pro/ToolbarFirstInputFocused.png

@@ -36,9 +36,6 @@ export const KeyboardControllerNative = (
       )
 ) as KeyboardControllerNativeModule;
 
-export const keyboardBorderRadius: number =
-  RCTKeyboardController?.getConstants()?.keyboardBorderRadius ?? 0;
-
 const KEYBOARD_CONTROLLER_NAMESPACE = "KeyboardController::";
 const eventEmitter = new NativeEventEmitter(KeyboardControllerNative);
 

e2e/kit/assets/ios/iPhone 17 Pro/ToolbarLastInputFocused.png

@@ -17,8 +17,6 @@ import type { EmitterSubscription } from "react-native";
 
 const NOOP = () => {};
 
-export const keyboardBorderRadius: number = 0;
-
 export const KeyboardControllerNative: KeyboardControllerNativeModule = {
   setDefaultMode: NOOP,
   setInputMode: NOOP,
@@ -29,6 +27,9 @@ export const KeyboardControllerNative: KeyboardControllerNativeModule = {
     Promise.resolve({ x: 0, y: 0, width: 0, height: 0 }),
   addListener: NOOP,
   removeListeners: NOOP,
+  getConstants: () => ({
+    keyboardBorderRadius: 0,
+  }),
 };
 /**
  * An event emitter that provides a way to subscribe to next keyboard events:

ios/KeyboardControllerModule.mm

@@ -1,4 +1,4 @@
-import { keyboardBorderRadius } from "../../bindings";
+import { KEYBOARD_BORDER_RADIUS } from "../../constants";
 
 import type { HEX } from "./types";
 
@@ -10,5 +10,5 @@ export const TEST_ID_KEYBOARD_TOOLBAR_DONE = `${TEST_ID_KEYBOARD_TOOLBAR}.done`;
 
 export const KEYBOARD_TOOLBAR_HEIGHT = 42;
 export const DEFAULT_OPACITY: HEX = "FF";
-export const KEYBOARD_HAS_ROUNDED_CORNERS = keyboardBorderRadius > 0;
+export const KEYBOARD_HAS_ROUNDED_CORNERS = KEYBOARD_BORDER_RADIUS > 0;
 export const OPENED_OFFSET = KEYBOARD_HAS_ROUNDED_CORNERS ? -11 : 0;