Describe the bug
The new useWindowDimensions function we added on ios seems to have lag or something it takes dimensions on rotation the opposite like hight is width and width is height i tested on Ipad 11 and on device and just saw the issue. Seems to be this issue facebook/react-native#29290 / facebook/react-native#49511. Is weird cause when tested on the repo that I shared in previous bug it was working at first glance but on my main repo it seems values are swapped even with screen approach. I used tablet this time and seems the bug is there. I will update more this issue when I get more time on my hand but for now I just wanted to let you know about this.
Code snippet
Add your code snippet where error has been occurred.
Repo for reproducing
https://github.com/Mako-L/problem-OverKeyboardView
To Reproduce
Steps to reproduce the behavior:
- Open the app on Ipad
- Go to chat
- rotate screen
- click attach icon button
- see problem
Expected behavior
It should take the dimensions correctly and have full screen modal but dimensions are swapped due to rn bug on Dimensions.
Screenshots
Smartphone (please complete the following information):
- Desktop OS: Mac latest
- Device: Ipad 11
- OS: 18.2
- RN version: 0.79.1 and 0.79.2
- RN architecture: new
- JS engine: idk
- Library version: github:kirillzyusko/react-native-keyboard-controller#main
Additional context
I think we should send the width and height from outside the module and use useSafeAreaFrame() to send them. I think we should add them as optional parameters and use if not null what do you think?
Describe the bug
The new useWindowDimensions function we added on ios seems to have lag or something it takes dimensions on rotation the opposite like hight is width and width is height i tested on Ipad 11 and on device and just saw the issue. Seems to be this issue facebook/react-native#29290 / facebook/react-native#49511. Is weird cause when tested on the repo that I shared in previous bug it was working at first glance but on my main repo it seems values are swapped even with screen approach. I used tablet this time and seems the bug is there. I will update more this issue when I get more time on my hand but for now I just wanted to let you know about this.
Code snippet
Add your code snippet where error has been occurred.
Repo for reproducing
https://github.com/Mako-L/problem-OverKeyboardView
To Reproduce
Steps to reproduce the behavior:
Expected behavior
It should take the dimensions correctly and have full screen modal but dimensions are swapped due to rn bug on Dimensions.
Screenshots
Smartphone (please complete the following information):
Additional context
I think we should send the width and height from outside the module and use useSafeAreaFrame() to send them. I think we should add them as optional parameters and use if not null what do you think?