feat: use keyboardAppearance instead of global appearance#1004
Merged
kirillzyusko merged 3 commits intomainfrom Jul 8, 2025
Merged
Conversation
Contributor
📊 Package size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Removed
defaultas a possible value ofappearanceproperty.💡 Motivation and Context
The thing is that for
defaulta real keyboard appearance can bedarkorlightdepending on device preferences. In this PR I decided to combine the logic on a native side and simplify JS logic, so for that I removeddefaultas a possible value from a native side.The other improvement is that we can consume
appearanceproperty fromuseKeyboardState. For that I had a separate listener toKeyboardEvents(keyboardWillShowevent), because we need to know the actual field value before keyboard appears.I removed a code that was responsible for detecting keyboard color from
KeyboardToolbar- now we can just useconst appearance = useKeyboardState(state => state.appearance)and don't go to low level stuff with setting up listeners. Just pass selector 😎📢 Changelog
JS
appearanceinuseKeyboardStatehook onwillShowevent;useKeyboardStateinstead ofuseColorScheme;iOS
defaultas possible value forappearance;Android
defaultas possible value forappearance;🤔 How Has This Been Tested?
Tested manually in example app.
📸 Screenshots (if appropriate):
📝 Checklist