Skip to content

fix: fix disabling KeyboardAvoidingView#1078

Merged
kirillzyusko merged 1 commit intokirillzyusko:mainfrom
itsramiel:fix/disabled-keyboard-avoiding-view
Aug 12, 2025
Merged

fix: fix disabling KeyboardAvoidingView#1078
kirillzyusko merged 1 commit intokirillzyusko:mainfrom
itsramiel:fix/disabled-keyboard-avoiding-view

Conversation

@itsramiel
Copy link
Copy Markdown
Contributor

@itsramiel itsramiel commented Aug 12, 2025

📜 Description

Fixes #1079
Returns empty style for disabled KeyboardAvoidingView to turn off all behaviors

💡 Motivation and Context

#1079

📢 Changelog

JS

iOS

Android

🤔 How Has This Been Tested?

Provided issue repo as well as in the example flatlist chat example of this repo

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko self-assigned this Aug 12, 2025
@kirillzyusko kirillzyusko self-requested a review August 12, 2025 11:40
@kirillzyusko kirillzyusko added 🐛 bug Something isn't working KeyboardAvoidingView 🧪 Anything related to KeyboardAvoidingView component labels Aug 12, 2025
@github-actions
Copy link
Copy Markdown
Contributor

📊 Package size report

Current size Target Size Difference
212766 bytes 212876 bytes -110 bytes 📉

@kirillzyusko
Copy link
Copy Markdown
Owner

I think it should do the trick. One thing that I found why I used enabled ? ... : 0 is only this line: c8a0d16#diff-1cca621b08199b8263bfb2a74dc05a83fc7c32b158b824ec19b8fc7db62ba90aR134-R135

I think I kind of used original code as a reference. But the proposed solution is much cleaner in terms of code readability, so let's merge it!

@kirillzyusko kirillzyusko merged commit aff3cbe into kirillzyusko:main Aug 12, 2025
12 checks passed
@itsramiel itsramiel deleted the fix/disabled-keyboard-avoiding-view branch August 13, 2025 06:39
@itsramiel
Copy link
Copy Markdown
Contributor Author

@kirillzyusko would you be able to create a release with these changes to use in the app I am working on?

@kirillzyusko
Copy link
Copy Markdown
Owner

@itsramiel hey, I'll definetely create a new release with new changes, but I think it may take a week (this is a typical release timeline for this package).

At the moment the difference between 1.18.4 and current main is only this PR, and yesterday new react-native was released. So I'd like to wait a little bit and fix all upcoming issues and then publish a new release. I hope it makes sense 😊

In a meantime you can use patch-package to patch the functionality. Sorry for the inconvenience caused and thank you for your contribution! ❤️

@itsramiel
Copy link
Copy Markdown
Contributor Author

Of course no worries. Thanks for letting me know! ❤️

@kirillzyusko
Copy link
Copy Markdown
Owner

@itsramiel fix is published in 1.18.5 version 🤞

@itsramiel
Copy link
Copy Markdown
Contributor Author

@kirillzyusko Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working KeyboardAvoidingView 🧪 Anything related to KeyboardAvoidingView component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

passing enabled={false} with behavior="translate-with-padding" does not disable KeyboardAvoidingView

2 participants