Skip to content

fix: clear legacy full screen flag#1098

Merged
kirillzyusko merged 1 commit intomainfrom
fix/clear-legacy-full-screen-flag
Aug 27, 2025
Merged

fix: clear legacy full screen flag#1098
kirillzyusko merged 1 commit intomainfrom
fix/clear-legacy-full-screen-flag

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Aug 27, 2025

📜 Description

Clear FLAG_FULLSCREEN when edge-to-edge view gets mounted.

💡 Motivation and Context

As per documentation:

A fullscreen window will ignore a value of SOFT_INPUT_ADJUST_RESIZE for the window's softInputMode field; the window will stay fullscreen and will not resize. 1

So if users specified somehow FLAG_FULLSCREEN it will ignore SOFT_INPUT_ADJUST_RESIZE and it will result in double animations.

Edge-to-edge seems to be a new FLAG_FULLSCREEN alternative which gives more control over things, because you can be full screen and still show StatusBar. So we have a right to clear that flag when we mount EdgeToEdge view 😊

Closes #1091

📢 Changelog

Android

  • clear FLAG_FULLSCREEN when edge-to-edge gets mounted/created.

🤔 How Has This Been Tested?

Tested manually on Pixel 9 Pro API 31.

📸 Screenshots (if appropriate):

Before After
Screen.Recording.2025-08-27.at.15.44.37.mov
Screen.Recording.2025-08-27.at.15.42.56.mov

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko marked this pull request as draft August 27, 2025 11:38
@kirillzyusko kirillzyusko self-assigned this Aug 27, 2025
@kirillzyusko kirillzyusko added 🐛 bug Something isn't working 🤖 android Android specific labels Aug 27, 2025
@github-actions
Copy link
Copy Markdown
Contributor

📊 Package size report

Current size Target Size Difference
212959 bytes 212904 bytes 55 bytes 📈

@kirillzyusko kirillzyusko marked this pull request as ready for review August 27, 2025 13:46
@kirillzyusko kirillzyusko merged commit 38217e6 into main Aug 27, 2025
16 checks passed
@kirillzyusko kirillzyusko deleted the fix/clear-legacy-full-screen-flag branch August 27, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 android Android specific 🐛 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank space upon closing the keyboard on few android versions

1 participant