fix: don't use @RequiresApi with old SDK versions#1107
Merged
kirillzyusko merged 4 commits intomainfrom Aug 29, 2025
Merged
Conversation
Contributor
📊 Package size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Removed
@RequiresApiannotations usage.💡 Motivation and Context
When I was getting compilation issues due to usage of API which is not available in older versions I was constantly using first option provided by Android Studio: to add
@RequiresApiannotation.However it has some downsides:
So to make code structure a little bit cleaner I decided to remove those annotations and switch to
if-statements. Initially the idea was to fix #1104, but turned out that [ObsoleteSdkInt] checks alsoif-statements. So for me as a library author there is only one reliable way to fix the issue is to suppress those warnings (if people set linter to treat warnings as errors it will prevent the lib from being compiled)Closes #1104
📢 Changelog
Android
@RequiresApitoif-statements;if-statements lint warnings via@SuppressLint;🤔 How Has This Been Tested?
Tested in example app.
📝 Checklist