feat: dismiss without animation#1127
Merged
kirillzyusko merged 5 commits intomainfrom Sep 30, 2025
Merged
Conversation
Contributor
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
f38a107 to
ef07cb9
Compare
Contributor
📊 Package size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added ability to hide keyboard instantly.
💡 Motivation and Context
This PR has been inspired by this post in twitter: https://x.com/klemensstrasser/status/1955284572825853957?t=Rui36_sZCd3pEoKFc02N9w&s=35
In this particular transition it makes sense to instantly hide the keyboard, so that main shared transition look consistent and additional animations don't distract the attention. So in this PR I'm adding a new option to
dismissmethod:animated. You can specifyfalseand then keyboard will be dismissed instantly. By default this option istrue, but when you develop complex shared animation transitions it may make sense to hide keyboard immediately 👀The other reason why I am adding this is because I've seen in some projects (Expensify, for example) that keyboard may be hidden instantly in some edge cases (that was a reminder that you need to use
onEndfor sync last animation frame). Now this is not the edge case, but something that we can control as well - so it will be easier to test various components, such asKeyboardAvoidingView/KeyboardAwareScrollViewto assure they work consistently with immediate close too.📢 Changelog
E2E
Docs
JS
animatedprop totypes.ts.iOS
performWithoutAnimationifanimatedistrue.Android
WindowInsetsControllerifanimatedistrue.🤔 How Has This Been Tested?
Tested on:
📸 Screenshots (if appropriate):
telegram-cloud-document-2-5393546018224636187.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-09-30.at.12.26.02.mp4
📝 Checklist