fix: attaching KeyboardTrackingView#1193
Merged
kirillzyusko merged 8 commits intomainfrom Nov 4, 2025
Merged
Conversation
kirillzyusko
added
🐛 bug
Contributor
📊 Package size report
|
kirillzyusko
force-pushed
the
fix/attaching-keyboard-tracking-view
branch
from
27c34d9 to
65c49a8
Compare
…eWindow` may return a wrong reference when non-transparent Modal gets shown (#1141)
kirillzyusko
commented
Nov 4, 2025
Owner
Author
There was a problem hiding this comment.
This is wrong, but we know that interactive keyboard doesn't work as expected. See #1140
kirillzyusko
commented
Nov 4, 2025
Owner
Author
There was a problem hiding this comment.
This is actually a bug spotted by e2e tests that was introduced in 1.19.4. The onMove handler wasn't working, so KeyboardAwareScrollView wasn't functioning properly 😓
|
waiting for the rlease to release our app |
Owner
Author
|
@joacub the fix has been published in |
2 tasks
kirillzyusko
added a commit
that referenced
this pull request
Jan 15, 2026
…case (#1277) ## 📜 Description Updated e2e asset for XCode 16 + iOS 26. ## 💡 Motivation and Context Fixing regression accidentally introduced in #1193 But #1161 fixes the problem 🤞 "Wow! I've been looking" message must be visible! ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### E2E - update `InteractiveKeyboardIsShown` asset for XCode 16 + iOS 26; ## 🤔 How Has This Been Tested? Tested manually via this PR and locally. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
2 tasks
kirillzyusko
added a commit
that referenced
this pull request
Jan 16, 2026
…case (#1279) ## 📜 Description Updated e2e asset for XCode 16 + iOS 26. ## 💡 Motivation and Context Fixing regression accidentally introduced in #1193 But #1161 fixes the problem 🤞 In #1277 I forgot to change keyboard to English-only layout 😓 "Wow! I've been looking" message must be visible! ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### E2E - update `InteractiveKeyboardIsShown` asset for XCode 16 + iOS 26; ## 🤔 How Has This Been Tested? Tested manually via this PR and locally. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed a problem of non working
onMovehandler in development builds.💡 Motivation and Context
In #1184 I started to rely that
didBecomeActiveevent will be caught and we can attach the view from this listener. But turns out that in dev builds we miss this event. So at the moment:KeyboardTrackingView(noticeable in release versions);didBecomeActivehierarchy is ready (but we may miss this event if we subscribed later, and also we rely on sequence of Apple events and it's kind of transitive dependencies that may break at any point of time).So I decided to re-work the approach. We attach
KeyboardControllerViewanyway, so I thought it's good to add a side effect indidMoveToWindowand attach ourKeyboardTrackingView. For that I added optional param toattachToTopmostViewmethod (calledtoWindow/window). If we pass the window then we use that param, otherwise rely onactiveWindowand takerootViewController.view.Such combination seems to solve all these issues when
onMovestops working under certain conditions. Now we always pass a window reference for a first mount and don't rely on internal Apple timing and events.Closes #1191
📢 Changelog
E2E
onMovehandler on iOS 26;iOS
KeyboardTrackingViewpublic;toWindow/windowintoattachToTopmostViewmethod;windowintoattachToTopmostViewfromdidMoveToWindowlifecycle.🤔 How Has This Been Tested?
Tested:
📸 Screenshots (if appropriate):
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-11-04.at.12.32.47.mov
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-11-04.at.12.25.28.mov
ScreenRecording_11-04-2025.13-23-45_1.MP4
📝 Checklist