-
-
Notifications
You must be signed in to change notification settings - Fork 154
fix: attaching KeyboardTrackingView
#1193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a0bcb21
fix: attaching `KeyboardTrackingView`
kirillzyusko 65c49a8
fix: swiftlint
kirillzyusko 1e7e8c2
fix: pass direct reference to window to avoid timing issues
kirillzyusko af5ab58
fix: swiftformat
kirillzyusko 42c326c
fix: actually use passed `window` reference
kirillzyusko beced24
fix: `attachToTopmostView` signature
kirillzyusko 60375b2
fix: iOS 26 e2e tests (update assets, since now they are correct)
kirillzyusko d09af45
fix: use `topViewController` instead of `activeWindow` because `activβ¦
kirillzyusko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+1.34 KB
(100%)
e2e/kit/assets/ios/iPhone 17 Pro/AwareScrollViewDisabledStateKeyboardClosed.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-361 Bytes
(100%)
e2e/kit/assets/ios/iPhone 17 Pro/AwareScrollViewDisabledStateKeyboardOpened.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1.34 KB
(100%)
...kit/assets/ios/iPhone 17 Pro/AwareScrollViewKeyboardClosedWithoutBackScroll.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-172 Bytes
(100%)
e2e/kit/assets/ios/iPhone 17 Pro/AwareScrollViewSecondInputFocused.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-646 Bytes
(100%)
e2e/kit/assets/ios/iPhone 17 Pro/InteractiveKeyboardIsShown.png
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is wrong, but we know that interactive keyboard doesn't work as expected. See #1140 |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a bug spotted by e2e tests that was introduced in
1.19.4. TheonMovehandler wasn't working, soKeyboardAwareScrollViewwasn't functioning properly π