-
-
Notifications
You must be signed in to change notification settings - Fork 153
feat: useAnimatedKeyboard compat layer
#1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import { useSharedValue } from "react-native-reanimated"; | ||
|
|
||
| import { useKeyboardHandler } from "./hooks"; | ||
|
|
||
| export const KeyboardState = { | ||
| UNKNOWN: 0, | ||
| OPENING: 1, | ||
| OPEN: 2, | ||
| CLOSING: 3, | ||
| CLOSED: 4, | ||
| }; | ||
|
|
||
| /** | ||
| * A compatibility layer for migration from https://docs.swmansion.com/react-native-reanimated/docs/device/useAnimatedKeyboard. | ||
| * | ||
| * @returns An object containing `height` and `state` properties represented as `SharedValue<number>`. | ||
| * @example | ||
| * ```ts | ||
| * import { useAnimatedKeyboard, useAnimatedStyle } from 'react-native-keyboard-controller'; | ||
| * | ||
| * export default function App() { | ||
| * const keyboard = useAnimatedKeyboard(); | ||
| * | ||
| * const animatedStyles = useAnimatedStyle(() => ({ | ||
| * transform: [{ translateY: -keyboard.height.value }], | ||
| * })); | ||
| * } | ||
| */ | ||
| export const useAnimatedKeyboard = () => { | ||
| const height = useSharedValue(0); | ||
| const state = useSharedValue(KeyboardState.UNKNOWN); | ||
|
|
||
| useKeyboardHandler( | ||
| { | ||
| onStart: (e) => { | ||
| "worklet"; | ||
|
|
||
| state.set(e.height > 0 ? KeyboardState.OPENING : KeyboardState.CLOSING); | ||
| }, | ||
| onMove: (e) => { | ||
| "worklet"; | ||
|
|
||
| height.set(e.height); | ||
| }, | ||
| onInteractive: (e) => { | ||
| "worklet"; | ||
|
|
||
| height.set(e.height); | ||
| }, | ||
| onEnd: (e) => { | ||
| "worklet"; | ||
|
|
||
| state.set(e.height > 0 ? KeyboardState.OPEN : KeyboardState.CLOSED); | ||
| height.set(e.height); | ||
| }, | ||
| }, | ||
| [], | ||
| ); | ||
|
|
||
| return { height, state }; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to memoize this config object with
useMemo?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tomekzaw You know this part better, so I'll do whatever you say. But let me explain it a little bit. Internally
useKeyboardHandlerusesuseEvent/useHandlerhooks from REA. And I tried to have the same API asuseAnimatedScrollHandlerwith only one difference - we attach handler to the view that is located inKeyboardProvider(it kind of makes sense because you have a single keyboard for whole app, but in case with ScrollView you may have multiple of them even on a single screen).From what I saw
useAnimatedScrollHandlerdoesn't memoize the config withuseMemo, right? Is it very expensive to create such object? (from plain react creating an object is a very cheap operation, but I'm not sure about "worklet" part, I think it also should be fast?)Anyway, the reason why I don't use
useMemois because I was trying to have the same API asuseAnimatedScrollHandlerand this hook doesn't useuseMemo🙃There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've asked @tjzel about this (he's our expert on memoization and worklets)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think
useMemoisn't necessary here, the gains would probably be marginal.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tjzel for a confirmation!