Skip to content

fix: avoid undesired reloadInputViews during keyboard dismissal #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirillzyusko merged 2 commits into from
Dec 9, 2025
Merged

fix: avoid undesired reloadInputViews during keyboard dismissal #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9e4e3
fix: avoid undesired `reloadInputViews` during keyboard dismissal
kirillzyusko Dec 8, 2025
d26f489
fix: iOS < 26 compatibility
kirillzyusko Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion FabricExample/src/screens/Examples/KeyboardExtender/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ export default function KeyboardExtendExample() {
return (
<>
<Image source={require("./background.jpg")} style={styles.background} />
<TouchableWithoutFeedback onPress={() => Keyboard.dismiss()}>
<TouchableWithoutFeedback
testID="keyboard_extender.dismiss"
onPress={() => Keyboard.dismiss()}
>
<SafeAreaView edges={["top"]} style={styles.container}>
<TextInput
keyboardType="numeric"
Expand Down
5 changes: 4 additions & 1 deletion example/src/screens/Examples/KeyboardExtender/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ export default function KeyboardExtendExample() {
return (
<>
<Image source={require("./background.jpg")} style={styles.background} />
<TouchableWithoutFeedback onPress={() => Keyboard.dismiss()}>
<TouchableWithoutFeedback
testID="keyboard_extender.dismiss"
onPress={() => Keyboard.dismiss()}
>
<SafeAreaView edges={["top"]} style={styles.container}>
<TextInput
keyboardType="numeric"
Expand Down
6 changes: 4 additions & 2 deletions ios/views/KeyboardExtenderContainerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ private class BaseContainerView: UIInputView {
}

func setupContainerSpecifics() {
// Override in subclasses
updateContentFrame(desiredHeight: calculateDesiredHeight())
}

func calculateDesiredHeight() -> CGFloat {
Expand All @@ -54,7 +54,7 @@ private class BaseContainerView: UIInputView {

let desiredHeight = calculateDesiredHeight()

if frame.height != desiredHeight {
if abs(frame.height - desiredHeight) > 0.001 {
frame.size.height = desiredHeight

updateContentFrame(desiredHeight: desiredHeight)
Expand Down Expand Up @@ -85,6 +85,7 @@ private class ModernContainerView: BaseContainerView {

override func setupContainerSpecifics() {
setupVisualEffect()
super.setupContainerSpecifics()
}

private func setupVisualEffect() {
Expand Down Expand Up @@ -128,6 +129,7 @@ private class ModernContainerView: BaseContainerView {
private class LegacyContainerView: BaseContainerView {
override func setupContainerSpecifics() {
addSubview(contentView)
super.setupContainerSpecifics()
}

override func updateContentFrame(desiredHeight _: CGFloat) {
Expand Down
Loading