Skip to content

refactor: change conditional code in KeyboardAvoidingView#1257

Merged
kirillzyusko merged 1 commit intomainfrom
fix/kav-for-web
Dec 23, 2025
Merged

refactor: change conditional code in KeyboardAvoidingView#1257
kirillzyusko merged 1 commit intomainfrom
fix/kav-for-web

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Dec 23, 2025

📜 Description

Compare OS only with ios string.

💡 Motivation and Context

We want KeyboardAvoidingView to have translate specific behavior only for iOS (because only this platform can smoothly animate instant changes). Before we were comparing OS with android to make it "android specific" behavior, but in reality it should be "non-iOS behavior", so i'm flipping the condition in this PR.

Since we support only two platforms it shouldn't make any difference, but for web which will work in the same way as android it makes a lot of sense, because otherwise it will not be able to animate it properly.

📢 Changelog

JS

  • flip OS === "android" into OS !== "ios" condition;

🤔 How Has This Been Tested?

Tested via this PR.

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko self-assigned this Dec 23, 2025
@kirillzyusko kirillzyusko added refactor You changed the code but it didn't affect functionality KeyboardAvoidingView 🧪 Anything related to KeyboardAvoidingView component labels Dec 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

📊 Package size report

Current size Target Size Difference
230183 bytes 230195 bytes -12 bytes 📉

@kirillzyusko kirillzyusko marked this pull request as ready for review December 23, 2025 19:39
@kirillzyusko kirillzyusko changed the title fix: KeyboardAvoidingView for web refactor: change conditional code in KeyboardAvoidingView Dec 23, 2025
@kirillzyusko kirillzyusko merged commit b5fb835 into main Dec 23, 2025
16 checks passed
@kirillzyusko kirillzyusko deleted the fix/kav-for-web branch December 23, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

KeyboardAvoidingView 🧪 Anything related to KeyboardAvoidingView component refactor You changed the code but it didn't affect functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant