refactor: change conditional code in KeyboardAvoidingView#1257
Merged
kirillzyusko merged 1 commit intomainfrom Dec 23, 2025
Merged
refactor: change conditional code in KeyboardAvoidingView#1257kirillzyusko merged 1 commit intomainfrom
KeyboardAvoidingView#1257kirillzyusko merged 1 commit intomainfrom
Conversation
Contributor
📊 Package size report
|
KeyboardAvoidingView for webKeyboardAvoidingView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Compare
OSonly withiosstring.💡 Motivation and Context
We want
KeyboardAvoidingViewto havetranslatespecific behavior only for iOS (because only this platform can smoothly animate instant changes). Before we were comparingOSwithandroidto make it "android specific" behavior, but in reality it should be "non-iOS behavior", so i'm flipping the condition in this PR.Since we support only two platforms it shouldn't make any difference, but for web which will work in the same way as android it makes a lot of sense, because otherwise it will not be able to animate it properly.
📢 Changelog
JS
OS === "android"intoOS !== "ios"condition;🤔 How Has This Been Tested?
Tested via this PR.
📝 Checklist