fix: call maybeScroll in onEnd handler in KeyboardAwareScrollView#1308
Open
kirillzyusko wants to merge 2 commits intomainfrom
Open
fix: call maybeScroll in onEnd handler in KeyboardAwareScrollView#1308kirillzyusko wants to merge 2 commits intomainfrom
maybeScroll in onEnd handler in KeyboardAwareScrollView#1308kirillzyusko wants to merge 2 commits intomainfrom
Conversation
Contributor
📊 Package size report
|
357c86a to
afaf76b
Compare
maybeScroll in onEnd handler in KeyboardAwareScrollView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Call
maybeScrollinonEndhandler.💡 Motivation and Context
The
onMovecan be missing because of many things:onMovekeyboard events on first app start.So in this PR I added
maybeScrollcall inonEnd. Before we were avoiding this, because on iOS we could have a situation whenendevent arrives beforestartbut it has been fixed in #1161 so it should be safe to do now 🤞📢 Changelog
JS
maybeScroll(e, false)inonEndhandler'🤔 How Has This Been Tested?
Tested via e2e tests 🤞
📸 Screenshots (if appropriate):
📝 Checklist