Skip to content

fix: call maybeScroll in onEnd handler in KeyboardAwareScrollView#1308

Open
kirillzyusko wants to merge 2 commits intomainfrom
fix/stable-ios-15-tests
Open

fix: call maybeScroll in onEnd handler in KeyboardAwareScrollView#1308
kirillzyusko wants to merge 2 commits intomainfrom
fix/stable-ios-15-tests

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Feb 10, 2026

📜 Description

Call maybeScroll in onEnd handler.

💡 Motivation and Context

The onMove can be missing because of many things:

  • resize event;
  • enabled a11y with reduced motion on Android;
  • iOS 15 may not have enough onMove keyboard events on first app start.

So in this PR I added maybeScroll call in onEnd. Before we were avoiding this, because on iOS we could have a situation when end event arrives before start but it has been fixed in #1161 so it should be safe to do now 🤞

📢 Changelog

JS

  • call maybeScroll(e, false) in onEnd handler'

🤔 How Has This Been Tested?

Tested via e2e tests 🤞

📸 Screenshots (if appropriate):

Before After
image image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko self-assigned this Feb 10, 2026
@kirillzyusko kirillzyusko added 🍎 iOS iOS specific KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component labels Feb 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 10, 2026

📊 Package size report

Current size Target Size Difference
280034 bytes 279973 bytes 61 bytes 📈

@kirillzyusko kirillzyusko force-pushed the fix/stable-ios-15-tests branch from 357c86a to afaf76b Compare March 4, 2026 10:16
@kirillzyusko kirillzyusko marked this pull request as ready for review March 11, 2026 11:55
@kirillzyusko kirillzyusko changed the title fix: stable ios 15 tests fix: call maybeScroll in onEnd handler in KeyboardAwareScrollView Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍎 iOS iOS specific KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant