Merged
Conversation
Contributor
📊 Package size report
|
e637a8a to
710d4c6
Compare
Contributor
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added
extraContentPaddingprop forKeyboardChatScrollViewcomponent.💡 Motivation and Context
This prop is very useful when you want to extend scrollable range and re-arrange the content so that it takes the same position as before (relatively). Theoretically "re-arrange" functionality must be configurable, but I tested many apps and what I can tell is that it looks like almost always this "re-arrange" respects
keyboardLiftBehaviorprop. Later we can introduce additional prop to have a better control, but for now we keep it simple.I was thinking on whether to make this prop a
SharedValueor a plain value and I decided to make itSharedValuebecause:animatedprop or smth like that);We also heavily use reanimated hooks internally, so integration with
SharedValuelooks very natural.I intentionally didn't want to modify original hooks and I extended functionality using new hook:
useExtraContentPadding. This new hook extendscontentInsets+ adjust scroll position. Maybe we'll et conflicts between hook in future, but at the moment it's extendable 😎Closes #1324
📢 Changelog
Docs
JS
extraContentPaddingprop forKeyboardChatScrollViewcomponent🤔 How Has This Been Tested?
Tested manually on:
📸 Screenshots (if appropriate):
telegram-cloud-document-2-5280683915592373225.mp4
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-05.at.17.31.28.mov
📝 Checklist