Skip to content

fix: KeyboardAvoidingView types union#1354

Merged
kirillzyusko merged 1 commit intomainfrom
fix/keyboard-avoiding-types-union
Mar 11, 2026
Merged

fix: KeyboardAvoidingView types union#1354
kirillzyusko merged 1 commit intomainfrom
fix/keyboard-avoiding-types-union

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Mar 11, 2026

📜 Description

Removed union type for KeyboardAvodiingView.

💡 Motivation and Context

Initially I thought that changes in #711 are cool, but in reality it causes more headache to devs because TS not always can understand which behavior passed etc. So after all attempts the easiest option is to remove conditional types.

Closes #1340

📢 Changelog

JS

  • don't use union types for KeyboardAvoidingView as it causes many TS errors where code is valid;

Example

  • ported automatic mode to FabricExample project;
  • moved options to separate file;

🤔 How Has This Been Tested?

Tested manually on iPhone 17 Pro (iOS 26.2).

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko self-assigned this Mar 11, 2026
@kirillzyusko kirillzyusko added 🐛 bug Something isn't working example Anything related to example project KeyboardAvoidingView 🧪 Anything related to KeyboardAvoidingView component labels Mar 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📊 Package size report

Current size Target Size Difference
301499 bytes 301688 bytes -189 bytes 📉

@kirillzyusko kirillzyusko marked this pull request as ready for review March 11, 2026 12:46
@kirillzyusko kirillzyusko merged commit f5dca3c into main Mar 11, 2026
15 of 16 checks passed
@kirillzyusko kirillzyusko deleted the fix/keyboard-avoiding-types-union branch March 11, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working example Anything related to example project KeyboardAvoidingView 🧪 Anything related to KeyboardAvoidingView component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyboardAvoidingViewProps: Types of property 'behavior' are incompatible.

1 participant