fix: KeyboardAwareScrollView regression after optimization#1387
Merged
kirillzyusko merged 1 commit intomainfrom Mar 21, 2026
Merged
fix: KeyboardAwareScrollView regression after optimization#1387kirillzyusko merged 1 commit intomainfrom
KeyboardAwareScrollView regression after optimization#1387kirillzyusko merged 1 commit intomainfrom
Conversation
Contributor
📊 Package size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Call
syncKeyboardFrameafterkeyboardHeighthas been set.💡 Motivation and Context
If we set call
syncKeyboardFrameandkeyboardHeight = 0, then interpolation simply doesn't work we interpolate between[0, 0]to[0, 0], so we get0. This regression has been introduced after #1381 changes and in this follow-up PR I'm fixing it 🤞The fix is quite straightforward - we just need to call
syncKeyboardFrameafter updatingkeyboardHeightvariable.Closes #1385
📢 Changelog
JS
syncKeyboardFrameafterkeyboardHeighthas been set.🤔 How Has This Been Tested?
Tested manually on iPhone 17 Pro (iOS 26.2).
📸 Screenshots (if appropriate):
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-21.at.16.39.01.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-21.at.16.36.55.mov
📝 Checklist