Skip to content

fix: KeyboardAwareScrollView regression after optimization#1387

Merged
kirillzyusko merged 1 commit intomainfrom
fix/kasw-regression-after-optimization
Mar 21, 2026
Merged

fix: KeyboardAwareScrollView regression after optimization#1387
kirillzyusko merged 1 commit intomainfrom
fix/kasw-regression-after-optimization

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Mar 21, 2026

📜 Description

Call syncKeyboardFrame after keyboardHeight has been set.

💡 Motivation and Context

If we set call syncKeyboardFrame and keyboardHeight = 0, then interpolation simply doesn't work we interpolate between [0, 0] to [0, 0], so we get 0. This regression has been introduced after #1381 changes and in this follow-up PR I'm fixing it 🤞

The fix is quite straightforward - we just need to call syncKeyboardFrame after updating keyboardHeight variable.

Closes #1385

📢 Changelog

JS

  • call syncKeyboardFrame after keyboardHeight has been set.

🤔 How Has This Been Tested?

Tested manually on iPhone 17 Pro (iOS 26.2).

📸 Screenshots (if appropriate):

Before After
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-21.at.16.39.01.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-21.at.16.36.55.mov

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko self-assigned this Mar 21, 2026
@kirillzyusko kirillzyusko added 🐛 bug Something isn't working KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component labels Mar 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📊 Package size report

Current size Target Size Difference
307041 bytes 306954 bytes 87 bytes 📈

@kirillzyusko kirillzyusko marked this pull request as ready for review March 21, 2026 15:51
@kirillzyusko kirillzyusko merged commit 90dd772 into main Mar 21, 2026
15 of 16 checks passed
@kirillzyusko kirillzyusko deleted the fix/kasw-regression-after-optimization branch March 21, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyboardAwareScrollView not working in 1.21.1

1 participant