Merged
Conversation
kirillzyusko
added
refactor
Contributor
📊 Package size report
|
2 tasks
kirillzyusko
added a commit
that referenced
this pull request
Mar 23, 2026
## 📜 Description Re-generate iOS snapshots tests. ## 💡 Motivation and Context After #1389 we identified, that on certain iOS versions `KeyboardAwareScrollView` snapshots were not matching previous results. It was only 1px, but it looks like it was enough to fail testing. In this PR I'm updating failed snapshots 🤞 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### E2E - updated iOS snapshots; ## 🤔 How Has This Been Tested? Tested via this PR. ## 📸 Screenshots (if appropriate): <img width="657" height="193" alt="image" src="https://github.com/user-attachments/assets/af33d30f-bb23-4928-9f10-1e72837878c2" /> ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Removed a fix with increased padding by
+1.💡 Motivation and Context
This code has been added in #342 But these changes became irrelevant after #1381 Since we started to change frame to full-height frame once per the animation we no longer have a condition described in #342
Additionally #332 is no longer reproducible, because in #797 we already were fighting with "ghost view" issue and fix for this problem also fixes #332 (just in a different way).
So to sum it up:
📢 Changelog
JS
+1to keyboard spacer size inKeyboardAwareScrollView;🤔 How Has This Been Tested?
Tested manually on Redmi Note 5 Pro (Android 9).
📸 Screenshots (if appropriate):
telegram-cloud-document-2-5334807169311219281.mp4
telegram-cloud-document-2-5334807169311219284.mp4
telegram-cloud-document-2-5334807169311219289.mp4
📝 Checklist