Skip to content

fix: KeyboardChatScrollView + RefreshControl conflict#1398

Merged
kirillzyusko merged 1 commit intomainfrom
fix/kcsv+refres-control-conflict
Mar 24, 2026
Merged

fix: KeyboardChatScrollView + RefreshControl conflict#1398
kirillzyusko merged 1 commit intomainfrom
fix/kcsv+refres-control-conflict

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Mar 24, 2026

📜 Description

Resolveda non-working KeyboardChatScrollView if it's used together with RefreshControl.

💡 Motivation and Context

If we use RefreshControl on Android it wraps whole ScrollView:

image

As a result getChildAt(0) will return RefreshControl view (not ScrollView) and whole decoration approach will fail.

To overcome this problem I added a small helper that traverse all children to find a necessary view to apply proper decoration. It fully fixes the problem.

Closes #1396

📢 Changelog

Android

  • added findScrollView helper;
  • use findScrollView instead of this.getChildAt(0) for more reliable ScrollView detection;

🤔 How Has This Been Tested?

Tested manually on Pixel 9 Pro API 35.

📸 Screenshots (if appropriate):

Before After
image image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@github-actions
Copy link
Copy Markdown
Contributor

📊 Package size report

Current size Target Size Difference
307713 bytes 307616 bytes 97 bytes 📈

@kirillzyusko kirillzyusko added the KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component label Mar 24, 2026
@kirillzyusko kirillzyusko marked this pull request as ready for review March 24, 2026 14:06
@kirillzyusko kirillzyusko merged commit 33a5d7b into main Mar 24, 2026
17 checks passed
@kirillzyusko kirillzyusko deleted the fix/kcsv+refres-control-conflict branch March 24, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 android Android specific 🐛 bug Something isn't working KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component KeyboardChatScrollView 💬 Anything about chat functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyboardChatScrollView content is hidden behind keyboard when used with refreshControl

1 participant