fix: KeyboardChatScrollView + RefreshControl conflict#1398
Merged
kirillzyusko merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
Contributor
📊 Package size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Resolveda non-working
KeyboardChatScrollViewif it's used together withRefreshControl.💡 Motivation and Context
If we use
RefreshControlon Android it wraps wholeScrollView:As a result
getChildAt(0)will returnRefreshControlview (notScrollView) and whole decoration approach will fail.To overcome this problem I added a small helper that traverse all children to find a necessary view to apply proper decoration. It fully fixes the problem.
Closes #1396
📢 Changelog
Android
findScrollViewhelper;findScrollViewinstead ofthis.getChildAt(0)for more reliableScrollViewdetection;🤔 How Has This Been Tested?
Tested manually on Pixel 9 Pro API 35.
📸 Screenshots (if appropriate):
📝 Checklist