Open
Conversation
kirillzyusko
added
enhancement
Contributor
📊 Package size report
|
This was referenced Mar 28, 2026
kirillzyusko
added a commit
that referenced
this pull request
Mar 31, 2026
## 📜 Description Added `keyboardBorderRadius` variable as exported constant from this module. ## 💡 Motivation and Context On iOS 26 keyboard started to have a rounded corners. However, if you compile app with XCode 26 or if you intentionally disable new keyboard via `plist` file you will get old keyboard. At the moment `KeyboardToolbar` relies on iOS 26 presence only and it may cause inconsistencies. In this PR I'm fixing it by adding an exported constant that indicates a radius of keyboard. Now we can compare it with `0` to understand which exactly keyboard is shown. These changes will also need to be present to make #1409 working across all devices 🤞 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### JS - declared `getConstants` method on native module; - updated TS spec and included new method signature; - declared `KEYBOARD_BORDER_RADIUS` in `constants` file; - used `KEYBOARD_BORDER_RADIUS` in `KeyboardToolbar` code. ### iOS - added `usesModernKeyboard` helper; - added `constantsToExport`/`getConstants` module method; ### Android - added `keyboardBorderRadius` variable as exported constant; - added `getConstants` method to module; ## 🤔 How Has This Been Tested? Tested manually fabric/paper on iPhone 15 (iOS 15.5)/iPhone 17 Pro (iOS 26.2)/Pixel 9 Pro (API 35). ## 📸 Screenshots (if appropriate): <img width="845" height="81" alt="image" src="https://github.com/user-attachments/assets/9453e160-831b-4d9f-b6e6-1967225f93a5" /> ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
kirillzyusko
force-pushed
the
feat/keyboard-effects
branch
from
949d5b5 to
75937de
Compare
kirillzyusko
force-pushed
the
feat/keyboard-effects
branch
from
6c708dc to
b568eed
Compare
kirillzyusko
force-pushed
the
feat/keyboard-effects
branch
from
7f7aa7a to
60fa3a6
Compare
kirillzyusko
force-pushed
the
feat/keyboard-effects
branch
from
38264b2 to
0602f3d
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
Initially I wanted to implement this UI:
ScreenRecording_03-27-2026.16-03-52_1.MP4
Closes #1410
📢 Changelog
JS
iOS
Android
🤔 How Has This Been Tested?
📸 Screenshots (if appropriate):
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-27.at.16.02.47.mov
📝 Checklist