fix: native rounded keyboard detection#1415
Merged
kirillzyusko merged 5 commits intomainfrom Mar 31, 2026
Merged
Conversation
Contributor
📊 Package size report
|
e5e5056 to
dfa89f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Added
keyboardBorderRadiusvariable as exported constant from this module.💡 Motivation and Context
On iOS 26 keyboard started to have a rounded corners. However, if you compile app with XCode 26 or if you intentionally disable new keyboard via
plistfile you will get old keyboard. At the momentKeyboardToolbarrelies on iOS 26 presence only and it may cause inconsistencies.In this PR I'm fixing it by adding an exported constant that indicates a radius of keyboard. Now we can compare it with
0to understand which exactly keyboard is shown.These changes will also need to be present to make #1409 working across all devices 🤞
📢 Changelog
JS
getConstantsmethod on native module;KEYBOARD_BORDER_RADIUSinconstantsfile;KEYBOARD_BORDER_RADIUSinKeyboardToolbarcode.iOS
usesModernKeyboardhelper;constantsToExport/getConstantsmodule method;Android
keyboardBorderRadiusvariable as exported constant;getConstantsmethod to module;🤔 How Has This Been Tested?
Tested manually fabric/paper on iPhone 15 (iOS 15.5)/iPhone 17 Pro (iOS 26.2)/Pixel 9 Pro (API 35).
📸 Screenshots (if appropriate):
📝 Checklist