fix: call syncUpLayout on iOS when keyboard changes its mode (emoji vs text)#1417
Merged
kirillzyusko merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
Contributor
📊 Package size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed a problem when switch text -> emoji -> text keeps pushing the content inside
KeyboardAwareScrollViewfurther and further.💡 Motivation and Context
The issue has been introduced in this PR: #760
The problem with:
Is that when keyboard resizes we never emit
syncUpLayoutevent. The fix proposed in this PR is safe, because:Another attempt to fix it has been added here #1407 But in #1407 we are trying to make JS code even more complex and the main problem is that with this fix documentation stays incorrect:
So this is a better fix that fixes a native side of the platform.
Closes #1318 #1407
📢 Changelog
iOS
syncUpLayoutif this event comes from keyboard notification;🤔 How Has This Been Tested?
Tested manually on iPhone 17 Pro (iOS 26.2) paper arch.
📸 Screenshots (if appropriate):
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-31.at.18.13.00.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-03-31.at.17.26.31.mov
📝 Checklist