feat: freeze in KeyboardChatScrollView as SharedValue#1434
Merged
kirillzyusko merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
Contributor
📊 Package size report
|
Contributor
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Make
freezeprop ofKeyboardChatScrollViewto supportSharedValue.💡 Motivation and Context
Fixing an architectural flow in
KeyboardChatScrollViewdesign 👀Initially I considered to use
freezeas aSharedValue. But I was thinking that it may reveal internal implementation so decided to use plain prop types (i. e. react state approach).However now I have a good use-case - if you are using
react-native-gesture-handlerfor handling button presses etc. you indeed may not need to jump to JS thread and then back to worklet if you can manage everything directly on UI thread.For compatibility reasons I decided to keep this prop as react prop + added
SharedValuesupport.Closes #1424
📢 Changelog
JS
SharedValuetype forfreezeprop;Docs
freezetype;🤔 How Has This Been Tested?
Tested in example project.
📝 Checklist