fix: use weak reference to keyboard view on iOS#1465
Merged
Conversation
Contributor
📊 Package size report
|
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Use
weakreference toKeyboardView.💡 Motivation and Context
The keyboard is a system view and we don't manage a lifecycle of this view. So we shouldn't try to keep a reference to it when view has been destroyed. For that we need to use
weakkeyword so that when keyboard instance has been destroyed we'll try to find a new instance of the keyboard.📢 Changelog
iOS
weakreference to the keyboard view inKeyboardViewLocator;🤔 How Has This Been Tested?
Tested via e2e tests. The issue has been discovered on iOS 26.2 (there after keyboard dismissal the reference is stale and keyboard is getting re-created when it's getting shown again).
📝 Checklist