Skip to content

fix(android): support NestedScrollView in ClippingScrollViewDecoratorView #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirillzyusko merged 1 commit into from
Jul 2, 2026
Merged

fix(android): support NestedScrollView in ClippingScrollViewDecoratorView #1527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions .../src/main/java/com/reactnativekeyboardcontroller/views/ClippingScrollViewDecoratorView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.view.MotionEvent
import android.view.View
import android.view.ViewGroup
import android.widget.ScrollView
import androidx.core.widget.NestedScrollView
import com.facebook.react.uimanager.ThemedReactContext
import com.facebook.react.views.view.ReactViewGroup
import com.reactnativekeyboardcontroller.extensions.px
Expand Down Expand Up @@ -100,7 +101,7 @@ class ClippingScrollViewDecoratorView(
}

private fun shouldUsePaddingScrollWorkaround(
scrollView: ScrollView,
scrollView: ViewGroup,
event: MotionEvent,
): Boolean {
val contentView = scrollView.getChildAt(0) ?: return false
Expand All @@ -115,7 +116,7 @@ class ClippingScrollViewDecoratorView(
}

private fun dispatchWithExpandedContentRange(
scrollView: ScrollView,
scrollView: ViewGroup,
event: MotionEvent,
): Boolean {
val contentView = scrollView.getChildAt(0)
Expand All @@ -136,7 +137,7 @@ class ClippingScrollViewDecoratorView(
}

private fun isTouchInScrollContent(
scrollView: ScrollView,
scrollView: ViewGroup,
event: MotionEvent,
): Boolean {
val contentView = scrollView.getChildAt(0) ?: return false
Expand All @@ -158,11 +159,15 @@ class ClippingScrollViewDecoratorView(
)
}

private fun findScrollView(view: View?): ScrollView? {
var result: ScrollView? = null
private fun findScrollView(view: View?): ViewGroup? {
var result: ViewGroup? = null

if (view is ScrollView) {
result = view
// Match NestedScrollView too: with React Native's `useNestedScrollViewAndroid`
// feature flag (RN 0.85+), ScrollView renders as a NestedScrollView subclass
// (a FrameLayout, not an android.widget.ScrollView). Both extend the scroll
// range via bottom padding + clipToPadding=false the same way.
if (view is ScrollView || view is NestedScrollView) {
result = view as ViewGroup
} else if (view is ViewGroup) {
var i = 0
while (i < view.childCount && result == null) {
Expand Down
Loading