Skip to content

fix: allow keyboard toolbar take all available space#865

Merged
kirillzyusko merged 3 commits intomainfrom
fix/allow-keyboard-toolbar-take-all-available-space
Mar 17, 2025
Merged

fix: allow keyboard toolbar take all available space#865
kirillzyusko merged 3 commits intomainfrom
fix/allow-keyboard-toolbar-take-all-available-space

Conversation

@kirillzyusko
Copy link
Copy Markdown
Owner

@kirillzyusko kirillzyusko commented Mar 17, 2025

📜 Description

Apply arrow/done paddings on elements level, not entire container, so that conditional rendering will exclude potentially undesired paddings.

💡 Motivation and Context

Potentially "padding by default" approach may be not desired when you want your custom element (content) to place that space.

So in this PR I re-worked an approach, and if done/arrows are hidden, then content will fill entire container.

Closes #848

Successor of #851

📢 Changelog

JS

  • removed paddingHorizontal from main container;
  • added container for arrows and apply padding there;
  • apply padding (+8px) to Done button (to compensate removed padding from main container);

🤔 How Has This Been Tested?

Tested manually on iPhone 15 Pro (iOS 17.5 Fabric).

📸 Screenshots (if appropriate):

No arrows No done button No toolbar elements All elements
image image image image

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added 🐛 bug Something isn't working KeyboardToolbar Anything related to KeyboardToolbar component labels Mar 17, 2025
@kirillzyusko kirillzyusko self-assigned this Mar 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 17, 2025

📊 Package size report

Current size Target Size Difference
169970 bytes 169908 bytes 62 bytes 📈

@kirillzyusko kirillzyusko marked this pull request as ready for review March 17, 2025 13:31
@kirillzyusko kirillzyusko merged commit 9080f31 into main Mar 17, 2025
12 checks passed
@kirillzyusko kirillzyusko deleted the fix/allow-keyboard-toolbar-take-all-available-space branch March 17, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working KeyboardToolbar Anything related to KeyboardToolbar component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyboardToolbar still shows container of arrows even when showArrows={false}

1 participant