fix: useKeyboardState tweaks#907
Merged
Merged
Conversation
kirillzyusko
added
documentation
Contributor
📊 Package size report
|
Contributor
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Revisited some concepts of
useKeyboardState/KeyboardController.state()etc.💡 Motivation and Context
After preparing a new release I went through the changes and realized, that it would be better to take a step back and keep
isVisible/statedecoupled butuseKeyboardStateshould return data to all variables (i. e. aggregate them).📢 Changelog
Docs
JS
isVisiblein.statemethodnullanymore;🤔 How Has This Been Tested?
Tested via CI.
📝 Checklist