fix: findNodeHandle on the web platform#912
Merged
kirillzyusko merged 1 commit intokirillzyusko:mainfrom Apr 17, 2025
Merged
Conversation
Contributor
📊 Package size report
|
Owner
|
Since I don't support web - it's okay to return element as node-handle. On web for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
In the new version of
react-native-webthey added an error throw if you try to use findNodeHandle fromreact-nativehttps://github.com/necolas/react-native-web/blob/922c134f2b7c428cc19daaeb3cac4b6a4c8ec6a3/packages/react-native-web/src/exports/findNodeHandle/index.js#L11. So I created a findNodeHandle utility that uses react-native's findNodeHandle for the native platform and returns Node or null for web.💡 Motivation and Context
This library should work well on all platforms
📢 Changelog
JS
🤔 How Has This Been Tested?
tested in a web browser
📸 Screenshots (if appropriate):
Before:
Screen.Recording.2025-04-10.at.11.20.20.mov
After:
Screen.Recording.2025-04-10.at.11.19.08.mov
📝 Checklist