Skip to content

fix: OverKeyboardView crash #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirillzyusko merged 2 commits into from
Apr 11, 2025
Merged

fix: OverKeyboardView crash #913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
493e300
fix: `OverKeyboardView` crash
kirillzyusko Apr 10, 2025
007f4f5
fix: ktlint
kirillzyusko Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions ...id/src/main/java/com/reactnativekeyboardcontroller/views/overlay/OverKeyboardViewGroup.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ import com.facebook.react.uimanager.events.EventDispatcher
import com.facebook.react.views.view.ReactViewGroup
import com.reactnativekeyboardcontroller.extensions.dp
import com.reactnativekeyboardcontroller.extensions.getDisplaySize
import com.reactnativekeyboardcontroller.log.Logger

private val TAG = OverKeyboardHostView::class.qualifiedName

@SuppressLint("ViewConstructor")
class OverKeyboardHostView(
Expand Down Expand Up @@ -140,17 +143,29 @@ class OverKeyboardRootViewGroup(
// region Touch events handling
override fun onInterceptTouchEvent(event: MotionEvent): Boolean {
eventDispatcher?.let { eventDispatcher ->
jsTouchDispatcher.handleTouchEvent(event, eventDispatcher)
jsPointerDispatcher?.handleMotionEventCompat(event, eventDispatcher, true)
try {
jsTouchDispatcher.handleTouchEvent(event, eventDispatcher)
jsPointerDispatcher?.handleMotionEventCompat(event, eventDispatcher, true)
} catch (
@Suppress("detekt:TooGenericExceptionCaught") e: RuntimeException,
) {
Logger.w(TAG, "Can not handle touch event", e)
}
}
return super.onInterceptTouchEvent(event)
}

@SuppressLint("ClickableViewAccessibility")
override fun onTouchEvent(event: MotionEvent): Boolean {
eventDispatcher?.let { eventDispatcher ->
jsTouchDispatcher.handleTouchEvent(event, eventDispatcher)
jsPointerDispatcher?.handleMotionEventCompat(event, eventDispatcher, false)
try {
jsTouchDispatcher.handleTouchEvent(event, eventDispatcher)
jsPointerDispatcher?.handleMotionEventCompat(event, eventDispatcher, false)
} catch (
@Suppress("detekt:TooGenericExceptionCaught") e: RuntimeException,
) {
Logger.w(TAG, "Can not handle touch event", e)
}
}
super.onTouchEvent(event)
// In case when there is no children interested in handling touch event, we return true from
Expand Down