fix: disabling KeyboardAwareScrollView didn't prevent useAnimatedStyle flickering

[High5Apps]

📜 Description

• Completely remove the Reanimated.View from KeyboardAwareScrollView when it's not enabled

💡 Motivation and Context

• There's an open issue with react-native Fabric that manifests as flickering and/or modal height issues when react-native-reanimated useAnimatedStyle values get out-of-sync with their underlying react native Fabric style values.
• Until the open issue is fixed, the simplest workaround for the issue seems to be removing instances of useAnimatedStyle
  • This is the same underlying motivation as your recent PR: feat: KeyboardStickyView using plain Animated #898
• My app has an issue where utilizing KeyboardAwareScrollView and then navigating to a new screen causes flickering in the second screen (see repro video below)
  • Others have reported similar issues: e.g. Layout flickering in routes presented over other routes which use a useAnimatedStyle react-navigation/react-navigation#12410
• I hoped that setting enabled based on whether the first screen was focused or not (using react navigation's useIsFocused hook) would work around the issue, but it didn't
• Fortunately, making the change in this PR, in addition to the enabled={isFocused} change mentioned above, fixed things (see no-repro video below)
  • For reference, here's my app's full workaround commit with a patch-package change that's the same as this PR
  • My app is using react-native-keyboard-controller@1.17.0 (current latest)

📢 Changelog

JS

• Completely remove the Reanimated.View from KeyboardAwareScrollView when it's not enabled

iOS

• N/A

Android

• N/A

🤔 How Has This Been Tested?

• Manually verified that:
  • the same set of repro steps showed the issue mentioned above without this PR change, but did not repro the issue with this PR change
  • keyboard avoidance still works on the screen's initial showing as well as when it's navigated back to
  • nothing breaks when navigating away from the screen while the keyboard is still active

📸 Screenshots (if appropriate):

Repro (without this PR)

repro.mp4

No-repro (with this PR)

no-repro.mp4

📝 Checklist

• CI successfully passed
• I added new mocks and corresponding unit-tests if library API was changed

[github-actions]

📊 Package size report

Current size	Target Size	Difference
176625 bytes	176578 bytes	47 bytes 📈

[kirillzyusko]

Thank you @High5Apps for such a detailed description ❤️

Changes look good for me, but it's 1 AM in my timezone - I approved PR to run CI and see if e2e tests pass or not (they should I believe, I don't see anything criminal in your changes).

Tomorrow I'll check again all attached references, to make sure I understood the problem and I think I'll merge it. Thank you again for your PR and your time 🙏

[High5Apps]

No problem, Kirill! Thanks for all of your great work on this library.

And no need to rush on this- get some sleep haha. I'm already using this with patch-package, so the PR is not a blocker for me. Just let me know if you need me to clarify anything or make changes, and I'll get to it some time tomorrow.

Thanks,
Julian

[kirillzyusko]

Looks good! Thank you for your contribution @High5Apps ❤️ 🙌