fix: support dynamic bottomOffset for KeyboardAwareScrollView#952
Merged
kirillzyusko merged 1 commit intomainfrom May 23, 2025
Merged
Conversation
Contributor
📊 Package size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
React on
bottomOffsetchanges reactively.💡 Motivation and Context
In current implementation we change callbacks and they will use an updated value in next calls, but the call to
maybeScrollfunction is missing.So in this PR I'm force-calling
maybeScrollwhenbottomOffsetgets changed, so in this way we always respect actualbottomOffsetvalue 😊Closes #930 #743
📢 Changelog
JS
maybeScrollwhenbottomOffsetgets changed;🤔 How Has This Been Tested?
Tested manually in FabricExample app with next code modification:
Verified by e2e tests that it doesn't introduce breaking changes.
📸 Screenshots (if appropriate):
Screen.Recording.2025-05-23.at.13.09.10.1.mov
📝 Checklist