refactor: don't inject package context#983
Merged
kirillzyusko merged 2 commits intomainfrom Jun 16, 2025
Merged
Conversation
Contributor
📊 Package size report
|
kirillzyusko
added
🤖 android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Don't pass
reactContextfromcreateViewManagersto a real view managers.💡 Motivation and Context
This seems to be a rudiment - for some reasons I had that code in the past, but now it seems completely unused and only pollutes Android Studio warnings that variable is unused.
I don't see any use cases where it would be actually used, so in this PR I'm removing that approach and now all magers are context-aware-free 🎉
📢 Changelog
Android
reactContextfromcreateViewManagersto a real view managers.🤔 How Has This Been Tested?
Tested via CI.
📸 Screenshots (if appropriate):
📝 Checklist