Feature/scheduler #7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "2.2.401" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| { | ||
| "RoslynExtensionsOptions": { | ||
| "enableAnalyzersSupport": true | ||
| }, | ||
| "FormattingOptions": { | ||
| "enableEditorConfigSupport": true | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| namespace KK.DotNet.BackgroundTasks.Scheduled.Sample.Web.Backgroundservices | ||
| { | ||
| using Microsoft.Extensions.Logging; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using KK.DotNet.BackgroundTasks.Scheduled; | ||
|
|
||
| public class RuntimeSampleTask : IScheduledTask | ||
| { | ||
| private readonly ILogger<RuntimeSampleTask> logger; | ||
|
|
||
| public RuntimeSampleTask( | ||
| IScheduledTaskOptions<RuntimeSampleTask> options, | ||
| ILogger<RuntimeSampleTask> logger | ||
| ) | ||
| { | ||
| this.Options = options; | ||
| this.logger = logger; | ||
| } | ||
|
|
||
| public IScheduledTaskOptions<IScheduledTask> Options { get; } | ||
|
|
||
| public async Task ExecuteAsync(CancellationToken stoppingToken) | ||
| { | ||
| this.logger.LogDebug("Runtime Sample Task started"); | ||
|
|
||
| _ = stoppingToken.Register(() => this.logger.LogDebug("Runtime Sample Task forced stopping.")); | ||
|
|
||
| var runCount = 0; | ||
| while (runCount < 5) | ||
|
There was a problem hiding this comment. Personally, I'd prefer a for-loop, but i assume thats a matter of style.
Owner
Author
There was a problem hiding this comment. good point, I will change this. |
||
| { | ||
| if (stoppingToken.IsCancellationRequested) | ||
| { | ||
| // Task was killed from outside. | ||
| this.logger.LogDebug($"{System.DateTime.Now} Runtime Sample Task cancellation requested!"); | ||
| return; | ||
| } | ||
|
|
||
| this.logger.LogDebug($"{System.DateTime.Now} Runtime Sample Task loop {runCount}"); | ||
| await Task.Delay(1000, stoppingToken); | ||
| runCount++; | ||
| } | ||
|
|
||
| this.logger.LogDebug("Runtime Sample Task is finished"); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| namespace KK.DotNet.BackgroundTasks.Scheduled.Sample.Web.Pages | ||
| { | ||
| using System.Diagnostics; | ||
| using Microsoft.AspNetCore.Mvc; | ||
| using Microsoft.AspNetCore.Mvc.RazorPages; | ||
|
|
||
| [ResponseCache(Duration = 0, Location = ResponseCacheLocation.None, NoStore = true)] | ||
| public class ErrorModel : PageModel | ||
| { | ||
| public string RequestId { get; set; } | ||
|
|
||
| public bool ShowRequestId => !string.IsNullOrEmpty(this.RequestId); | ||
|
|
||
| public void OnGet() | ||
| => this.RequestId = Activity.Current?.Id ?? this.HttpContext.TraceIdentifier; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| @page | ||
| @model IndexModel | ||
| @{ | ||
| ViewData["Title"] = "Home page"; | ||
| } | ||
|
|
||
| <div class="text-center"> | ||
| <h1 class="display-4">Welcome</h1> | ||
| <p>Learn about <a href="https://docs.microsoft.com/aspnet/core">building Web apps with ASP.NET Core</a>.</p> | ||
| <p>Scheduled Tasks running: @Model.Scheduler.Tasks.Count</p> | ||
| @foreach (var task in @Model.Scheduler.Tasks) | ||
| { | ||
| <p><strong>Name</strong>: @task.Name <br /><strong>NextStartTime</strong>: @task.NextStartTime</p> | ||
| } | ||
| <form method="POST"> | ||
| <div>Name: <input asp-for="Options.Name" /></div> | ||
| <div>Name: <input asp-for="Options.Schedule" /></div> | ||
| <input value="Add Task" type="submit" /> | ||
| </form> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| namespace KK.DotNet.BackgroundTasks.Scheduled.Sample.Web.Pages | ||
| { | ||
| using System.Threading.Tasks; | ||
| using KK.DotNet.BackgroundTasks.Scheduled.Sample.Web.Backgroundservices; | ||
| using Microsoft.AspNetCore.Mvc; | ||
| using Microsoft.AspNetCore.Mvc.RazorPages; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| public class IndexModel : PageModel | ||
| { | ||
| private readonly ILogger<RuntimeSampleTask> runtimeSampleTaskLogger; | ||
|
There was a problem hiding this comment. Also matter of preference but: since almost all classes only have one logger, I call them all the same: "logger". I only call them differently if there are different loggers in a given class to make myself and others aware that this might not be the logger one wants to use. Also, the shorter name might allow you to put the parameters in lines 22ff on a single line.
Owner
Author
There was a problem hiding this comment. That's a good point, I will change that. |
||
|
|
||
| public Scheduler Scheduler { get; } | ||
|
|
||
|
|
||
| [BindProperty] | ||
| public ScheduledTaskOptions<RuntimeSampleTask> Options { get; set; } | ||
|
|
||
| // When using the default SchedulerHostedService than there is also a Scheduler | ||
| // this can be used to get access to the scheduled task list for example | ||
| public IndexModel( | ||
| Scheduler scheduler, | ||
| ILogger<RuntimeSampleTask> runtimeSampleTaskLogger | ||
| ) | ||
| { | ||
| this.Scheduler = scheduler; | ||
| this.runtimeSampleTaskLogger = runtimeSampleTaskLogger; | ||
| this.Options = new ScheduledTaskOptions<RuntimeSampleTask>() | ||
| { | ||
| Name = "Awesome Runntime Task", | ||
| Schedule = "*/15 * * * *" | ||
| }; | ||
| } | ||
|
|
||
| public void OnGet() | ||
| { | ||
| //this.Scheduler.SchedulerTasks; | ||
| } | ||
|
|
||
| public IActionResult OnPost() | ||
| { | ||
| if (!this.ModelState.IsValid) | ||
| { | ||
| return this.Page(); | ||
| } | ||
|
|
||
| this.Scheduler.AddTask(new RuntimeSampleTask(this.Options, this.runtimeSampleTaskLogger)); | ||
|
|
||
| return this.Page(); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| @page | ||
| @model PrivacyModel | ||
| @{ | ||
| ViewData["Title"] = "Privacy Policy"; | ||
| } | ||
| <h1>@ViewData["Title"]</h1> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| namespace KK.DotNet.BackgroundTasks.Scheduled.Sample.Web.Pages | ||
| { | ||
| using Microsoft.AspNetCore.Mvc.RazorPages; | ||
|
|
||
| public class PrivacyModel : PageModel | ||
| { | ||
| public void OnGet() | ||
| { | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to newest version