refactor: propagate IOException handling in reader.FolderStrategy and reader.ZipStrategy

Author: Pfeil

src/main/java/edu/kit/datamanager/ro_crate/reader/FolderStrategy.java

@@ -17,15 +17,11 @@
 public class FolderStrategy implements GenericReaderStrategy<String> {
 
   @Override
-  public ObjectNode readMetadataJson(String location) {
+  public ObjectNode readMetadataJson(String location) throws IOException {
     Path metadata = new File(location).toPath().resolve("ro-crate-metadata.json");
     ObjectMapper objectMapper = MyObjectMapper.getMapper();
     ObjectNode objectNode = objectMapper.createObjectNode();
-    try {
-      objectNode = objectMapper.readTree(metadata.toFile()).deepCopy();
-    } catch (IOException e) {
-      e.printStackTrace();
-    }
+    objectNode = objectMapper.readTree(metadata.toFile()).deepCopy();
     return objectNode;
   }
 

src/main/java/edu/kit/datamanager/ro_crate/reader/ZipStrategy.java

@@ -80,29 +80,25 @@ public boolean isExtracted() {
     return isExtracted;
   }
 
-  private void readCrate(String location) {
-    try {
-      File folder = temporaryFolder.toFile();
-      // ensure the directory is clean
-      if (folder.isDirectory()) {
-        FileUtils.cleanDirectory(folder);
-      } else if (folder.isFile()) {
-        FileUtils.delete(folder);
-      }
-      // extract
-      try (ZipFile zf = new ZipFile(location)) {
-        zf.extractAll(temporaryFolder.toAbsolutePath().toString());
-        this.isExtracted = true;
-      }
-      // register deletion on exit
-      FileUtils.forceDeleteOnExit(folder);
-    } catch (IOException e) {
-      e.printStackTrace();
+  private void readCrate(String location) throws IOException {
+    File folder = temporaryFolder.toFile();
+    // ensure the directory is clean
+    if (folder.isDirectory()) {
+      FileUtils.cleanDirectory(folder);
+    } else if (folder.isFile()) {
+      FileUtils.delete(folder);
     }
+    // extract
+    try (ZipFile zf = new ZipFile(location)) {
+      zf.extractAll(temporaryFolder.toAbsolutePath().toString());
+      this.isExtracted = true;
+    }
+    // register deletion on exit
+    FileUtils.forceDeleteOnExit(folder);
   }
 
   @Override
-  public ObjectNode readMetadataJson(String location) {
+  public ObjectNode readMetadataJson(String location) throws IOException {
     if (!isExtracted) {
       this.readCrate(location);
     }
@@ -123,17 +119,12 @@ public ObjectNode readMetadataJson(String location) {
         .orElseThrow(() -> new IllegalStateException("No %s found in zip file".formatted(JsonDescriptor.ID)));
       jsonMetadata = firstSubdir.toPath().resolve(JsonDescriptor.ID).toFile();
     }
-    
-    try {
-      return objectMapper.readTree(jsonMetadata).deepCopy();
-    } catch (IOException e) {
-      e.printStackTrace();
-      return null;
-    }
+
+    return objectMapper.readTree(jsonMetadata).deepCopy();
   }
 
   @Override
-  public File readContent(String location) {
+  public File readContent(String location) throws IOException {
     if (!isExtracted) {
       this.readCrate(location);
     }