chore: fix small linter complaints in AbstractEntity and ClasspathPropertiesVersionProvider

Author: Pfeil

src/main/java/edu/kit/datamanager/ro_crate/entities/AbstractEntity.java

@@ -254,9 +254,7 @@ private static boolean addProperty(ObjectNode whereToAdd, String key, JsonNode v
     public void addIdProperty(String name, String id) {
         if (id == null || id.isBlank()) { return; }
         mergeIdIntoValue(id, this.properties.get(name))
-                .ifPresent(newValue -> {
-                    this.properties.set(name, newValue);
-                });
+                .ifPresent(newValue -> this.properties.set(name, newValue));
         this.linkedTo.add(id);
         this.notifyObservers();
     }
@@ -369,7 +367,7 @@ private static void checkFormatISO8601(String date) throws IllegalArgumentExcept
     /**
      * Adds a property with date time format. The property should match the ISO 8601
      * date format.
-     * 
+     * <p>
      * Same as {@link #addProperty(String, String)} but with internal check.
      *
      * @param key   key of the property (e.g. datePublished)
@@ -424,7 +422,7 @@ public T setId(String id) {
                 if (IdentifierUtils.isValidUri(id)) {
                     this.id = id;
                 } else {
-                    this.id = IdentifierUtils.encode(id).get();
+                    this.id = IdentifierUtils.encode(id).orElse(this.id);
                 }
             }
             return self();
@@ -461,7 +459,7 @@ public T addTypes(Collection<String> types) {
         /**
          * Adds a property with date time format. The property should match the ISO 8601
          * date format.
-         * 
+         * <p>
          * Same as {@link #addProperty(String, String)} but with internal check.
          *
          * @param key   key of the property (e.g. datePublished)
@@ -521,7 +519,7 @@ public T addProperty(String key, boolean value) {
         /**
          * ID properties are often used when referencing other entities within
          * the ROCrate. This method adds automatically such one.
-         * 
+         * <p>
          * Instead of {@code "name": "id" }
          * this will add {@code "name" : {"@id": "id"} }
          * 

src/main/java/edu/kit/datamanager/ro_crate/util/ClasspathPropertiesVersionProvider.java

@@ -6,8 +6,7 @@
 import java.util.Properties;
 
 public class ClasspathPropertiesVersionProvider implements VersionProvider {
-    private static final String PROPERTIES_FILE = "ro-crate-java.properties";
-    private static final String VERSION_KEY = "version";
+    public static final String VERSION_PROPERTIES = "version.properties";
 
     /**
      * Cached version to avoid repeated file/resource reads.
@@ -27,14 +26,14 @@ public String getVersion() {
             return cachedVersion;
         }
 
-        URL resource = this.getClass().getResource("/version.properties");
-        assert resource != null : "version.properties not found in classpath";
+        URL resource = this.getClass().getResource("/" + VERSION_PROPERTIES);
+        assert resource != null : VERSION_PROPERTIES + " not found in classpath";
 
         try (InputStream input = resource.openStream()) {
             Properties properties = new Properties();
             properties.load(input);
             String version = properties.getProperty("version");
-            assert version != null : "Version property not found in version.properties";
+            assert version != null : "Version property not found in " + VERSION_PROPERTIES;
             return version.trim();
         } catch (IOException e) {
             throw new IllegalStateException("Failed to read version from properties file", e);