fixing F5 issue + scheme for invalidating the context+scanner caches.

Author: unrenormalizable

src/RustAnalyzer/Debugger/DebugLaunchTargetProvider.cs

@@ -45,6 +45,7 @@ public bool SupportsContext(IWorkspace workspaceContext, string targetFilePath)
 
     private async Task LaunchDebugTargetAsync(IWorkspace workspaceContext, IServiceProvider serviceProvider, LaunchConfigWrapper lcw, CancellationToken ct)
     {
+        const string diagMessage = "Delete the .vs folder and try again. If that does not work please file a bug with the repro steps.";
         try
         {
             var mds = workspaceContext.GetService<IMetadataService>();
@@ -54,20 +55,20 @@ private async Task LaunchDebugTargetAsync(IWorkspace workspaceContext, IServiceP
             var target = package.GetTargets().FirstOrDefault(t => t.QualifiedTargetFileName == targetFQN);
             if (target == null)
             {
-                string message = string.Format("Cannot find target '{0}' in '{1}', for profile '{2}'. This indicates a bug in the manifest parsing logic. Unable to start debugging.", targetFQN, package?.FullPath, profile);
+                string message = string.Format("Cannot find target '{0}' in '{1}', for profile '{2}'.", targetFQN, package?.FullPath, profile);
                 L.WriteError(message);
                 T.TrackException(new ArgumentOutOfRangeException("target", message));
-                await VsCommon.ShowMessageBoxAsync(message, "Try again after deleting the .vs folder. If that does not work please file a bug.");
+                await VsCommon.ShowMessageBoxAsync(message, diagMessage);
                 return;
             }
 
             var processName = target.GetPath(profile);
             if (!File.Exists(processName))
             {
-                var message = string.Format("Unable to find file: '{0}'. This indicates a bug with the Manifest parsing logic. Unable to start debugging.", processName);
+                var message = string.Format("Unable to find file: '{0}'.", processName);
                 L.WriteLine(message);
                 T.TrackException(new FileNotFoundException(message, processName));
-                await VsCommon.ShowMessageBoxAsync(message, "Try again after deleting the .vs folder. If that does not work please file a bug.");
+                await VsCommon.ShowMessageBoxAsync(message, diagMessage);
                 return;
             }
 

src/RustAnalyzer/Editor/FileContextProviderFactory.cs

@@ -14,9 +14,9 @@ namespace KS.RustAnalyzer.Editor;
     supportedContextTypeGuids: new[] { BuildContextTypes.BuildContextType, BuildContextTypes.CleanContextType, })]
 public sealed class FileContextProviderFactory : IWorkspaceProviderFactory<IFileContextProvider>
 {
-    public static readonly Guid ProviderTypeGuid = new(ProviderType);
+    public const string ProviderType = "72D3FCEF-0001-4266-B8DD-D3ED06E35A2B";
 
-    private const string ProviderType = "{72D3FCEF-0000-4266-B8DD-D3ED06E35A2B}";
+    public static readonly Guid ProviderTypeGuid = new(ProviderType);
 
     [Import]
     public IBuildOutputSink OutputPane { get; set; }

src/RustAnalyzer/Editor/FileScanner.cs

@@ -1,8 +1,10 @@
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
+using KS.RustAnalyzer.TestAdapter;
 using KS.RustAnalyzer.TestAdapter.Cargo;
 using KS.RustAnalyzer.TestAdapter.Common;
 using Microsoft.VisualStudio.Workspace;
@@ -12,7 +14,7 @@
 
 namespace KS.RustAnalyzer.Editor;
 
-public class FileScanner : IFileScanner
+public class FileScanner : IFileScanner, IFileScannerUpToDateCheck
 {
     private readonly IMetadataService _mds;
 
@@ -46,6 +48,32 @@ public async Task<T> ScanContentAsync<T>(string filePath, CancellationToken canc
         }
     }
 
+    public virtual async Task<bool> IsUpToDateAsync(DateTimeOffset? lastScanTimestamp, string filePath, FileScannerType scannerType, CancellationToken cancellationToken)
+    {
+        if (await IsValidFileAsync(filePath))
+        {
+            try
+            {
+                var lastWrite = File.GetLastWriteTimeUtc(filePath);
+                return lastScanTimestamp.HasValue && lastWrite < lastScanTimestamp.Value.UtcDateTime;
+            }
+            catch (Exception exc) when (exc is IOException || exc is UnauthorizedAccessException)
+            {
+                // We have already loaded the file in VS,
+                // so any I/O related exceptions are very unlikely
+                // and we def. don't want to crash VS on that.
+            }
+        }
+
+        return false;
+    }
+
+    private Task<bool> IsValidFileAsync(string filePath)
+    {
+        var ext = ((PathEx)filePath).GetExtension();
+        return (ext.Equals(Constants.RustFileExtension) || ext.Equals(Constants.ManifestFileExtension)).ToTask();
+    }
+
     private List<FileDataValue> GetFileDataValues(Workspace.Package package, PathEx filePath)
     {
         var allFileDataValues = new List<FileDataValue>();

src/RustAnalyzer/Editor/FileScannerFactory.cs

@@ -17,7 +17,8 @@ namespace KS.RustAnalyzer.Editor;
     priority: ProviderPriority.Normal)]
 public class FileScannerFactory : IWorkspaceProviderFactory<IFileScanner>
 {
-    public const string ProviderType = "F5628EAD-0000-4683-B597-D8314B971ED6";
+    public const string ProviderType = "F5628EAD-0001-4683-B597-D8314B971ED6";
+
     public static readonly Guid ProviderTypeGuid = new(ProviderType);
 
     [Import]