Add optional d3js parameter#246
Draft
hyanwong wants to merge 4 commits into
Draft
Conversation
hyanwong
force-pushed
the
copilot/add-optional-d3js-parameter
branch
2 times, most recently
from
7db102a to
39904f5
Compare
Contributor
Author
|
This is almost ready for review. It allows the arg visualiser to be used offline, if a local copy of d3js is provided. There are probably some other online resources needed for full functionality, e.g. require.js, and fileSaver. I think the first can be swapped out in more recent browsers, |
Contributor
Author
|
Waiting for #248 before review |
Agent-Logs-Url: https://github.com/hyanwong/tskit_arg_visualizer/sessions/8e87ee51-107a-41cd-a17c-213483a067b9 Co-authored-by: hyanwong <4699014+hyanwong@users.noreply.github.com>
hyanwong
force-pushed
the
copilot/add-optional-d3js-parameter
branch
from
39904f5 to
79b9267
Compare
hyanwong
force-pushed
the
copilot/add-optional-d3js-parameter
branch
from
79b9267 to
abb715f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done in conjunction with copilot.
Maybe we should implement a simple test framework first.(now implemented)