Drop require.js and load d3 directly in browser entry scripts#248
Open
hyanwong wants to merge 1 commit into
Open
Drop require.js and load d3 directly in browser entry scripts#248hyanwong wants to merge 1 commit into
hyanwong wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to chatGPT, in modern browsers we can get away without require.js (i.e. the comments in #131 are outdated).
It would be nice to remove this, because together with #246 it enables fully offline use (this PR removes the require.js CDN call; #246 handles the D3 CDN call).
I have tested the current PR in a notebook, and it seems to work fine. So my suggestion would be to merge this to remove the require.js dependency (removing deps where possible seems sensible anyway)