Add dense vector field#72
Conversation
davisagli
left a comment
There was a problem hiding this comment.
@reekitconcept Do you see any problem with adding this?
…nction to dot_product & remove params with default values
|
@davisagli I removed parameters where the value matches Solr's default, keeping only the ones we're explicitly overriding. The ones that are specified are:
I left This seemed to me like a reasonable starting point, but probably will be tuned as we move forward. |
|
@danalvrz Thanks, that explanation is helpful, and I think having it here is enough in case someone wants to track down later why we picked the settings we did. |
|
@danalvrz Balazs told me he'll take a look when he's back tomorrow |
reekitconcept
left a comment
There was a problem hiding this comment.
I don't see any problem. I have not tested it but I would say if the CI passes then we are good.
No description provided.