Skip to content

Add dense vector field#72

Merged
danalvrz merged 3 commits into
mainfrom
add-dense-vector-field
May 7, 2026
Merged

Add dense vector field#72
danalvrz merged 3 commits into
mainfrom
add-dense-vector-field

Conversation

@danalvrz
Copy link
Copy Markdown
Collaborator

No description provided.

@danalvrz danalvrz requested a review from davisagli April 24, 2026 12:15
Copy link
Copy Markdown
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reekitconcept Do you see any problem with adding this?

Comment thread solr/etc/conf/schema.xml Outdated
Comment thread solr/etc/conf/schema.xml Outdated
@davisagli davisagli requested a review from reekitconcept April 24, 2026 17:54
@danalvrz
Copy link
Copy Markdown
Collaborator Author

@davisagli I removed parameters where the value matches Solr's default, keeping only the ones we're explicitly overriding.

The ones that are specified are:

I left hnswM as default (16) because in https://arxiv.org/pdf/1603.09320 and https://opensearch.org/blog/a-practical-guide-to-selecting-hnsw-hyperparameters/ it does not seem to be a very large improvement in the recall with larger numbers of links per node, and the memory impact increases linearly. It also increases query latency and indexing time.

This seemed to me like a reasonable starting point, but probably will be tuned as we move forward.

@davisagli
Copy link
Copy Markdown
Member

@danalvrz Thanks, that explanation is helpful, and I think having it here is enough in case someone wants to track down later why we picked the settings we did.

@davisagli
Copy link
Copy Markdown
Member

@danalvrz Balazs told me he'll take a look when he's back tomorrow

Copy link
Copy Markdown
Member

@reekitconcept reekitconcept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problem. I have not tested it but I would say if the CI passes then we are good.

@danalvrz danalvrz merged commit eaa5161 into main May 7, 2026
5 checks passed
@danalvrz danalvrz deleted the add-dense-vector-field branch May 7, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants